Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added translation to t&c portion of signup #3275

Conversation

mohankumarhr
Copy link

@mohankumarhr mohankumarhr commented Nov 13, 2024

Fixes #3274

Changes:
Added translation for t&c portion of the signup page

Description

"By signing up, you agree to the p5.js Editor's Terms of Use and Privacy Policy." This line in the signup page is translated to below-mentioned languages

Translated Languages
German - Deutsch
Spanish - Español
French - Français
Italian - Italiano
korean - 한국어
Portuguese - Português
Swedish - Svenska
Ukrainian - Українська
Urdu - اردو
Simplified Chinese - 简体中文
Traditional Chinese - 正體中文

All the translations are done using Google Translator and Cambridge Dictionary

Screenshot (24)

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Nov 13, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Nov 13, 2024

Thanks for starting the work on these!

Ideally, we'd love to get native speakers' eyes on these translations before merging them in to ensure that they're correct. It would also be great if you could add to the description the languages you've translated and how you created these translations.

@mohankumarhr
Copy link
Author

mohankumarhr commented Nov 13, 2024

For these translations, I used Google Translate and the Cambridge Dictionary websites as the main tools also I've mentioned the languages which i have translated and I’m happy to incorporate any additional feedback. Let me know if you need any further information or adjustments from my side!

@raclim
Copy link
Collaborator

raclim commented Nov 13, 2024

Awesome, thanks so much for adding these! If you know any folks who are proficient in those languages feel free to tag them! I'll try to do so as well!

@prudvinani
Copy link

@raclim hey want to work on this issue,can you please assign it to me

@Harshit-7373
Copy link
Contributor

@mohankumarhr @raclim I found an error in this PR. The translations in the languages I know (English, French, Portuguese, Hindi, and Korean) indicate that the changes are based on this line: "By signing up, you agree to the terms of the p5.js publisher's Terms of Use and Privacy Policy." However, it should be changed to "By signing up, you agree to the p5.js Editor's Terms of Use and Privacy Policy."

I believe "publisher" should be replaced with "editor." Please let me know your thoughts.

@raclim
Copy link
Collaborator

raclim commented Mar 6, 2025

After giving it some thought on how we want to handle translations, I think we might want to move away from accepting large submissions with a lot of different languages, and gear towards 1-2 languages per submission. Ideally, the 1-2 languages should be ones that the contributor should know and speak natively to ensure that we're getting proper translations. The reason for this shift is that I feel that we should encourage moving away from machine translations, and to have PRs be as ready for submission as possible.

I'm going to close this one for now—I'm sorry that we couldn't get this in, but please feel free to resubmit this PR with translations for any languages that you personally know!

@raclim raclim closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the t&c portion of the signup page isn't translated correctly
4 participants