-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added translation to t&c portion of signup #3275
added translation to t&c portion of signup #3275
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Thanks for starting the work on these! Ideally, we'd love to get native speakers' eyes on these translations before merging them in to ensure that they're correct. It would also be great if you could add to the description the languages you've translated and how you created these translations. |
For these translations, I used Google Translate and the Cambridge Dictionary websites as the main tools also I've mentioned the languages which i have translated and I’m happy to incorporate any additional feedback. Let me know if you need any further information or adjustments from my side! |
Awesome, thanks so much for adding these! If you know any folks who are proficient in those languages feel free to tag them! I'll try to do so as well! |
@raclim hey want to work on this issue,can you please assign it to me |
@mohankumarhr @raclim I found an error in this PR. The translations in the languages I know (English, French, Portuguese, Hindi, and Korean) indicate that the changes are based on this line: "By signing up, you agree to the terms of the p5.js publisher's Terms of Use and Privacy Policy." However, it should be changed to "By signing up, you agree to the p5.js Editor's Terms of Use and Privacy Policy." I believe "publisher" should be replaced with "editor." Please let me know your thoughts. |
After giving it some thought on how we want to handle translations, I think we might want to move away from accepting large submissions with a lot of different languages, and gear towards 1-2 languages per submission. Ideally, the 1-2 languages should be ones that the contributor should know and speak natively to ensure that we're getting proper translations. The reason for this shift is that I feel that we should encourage moving away from machine translations, and to have PRs be as ready for submission as possible. I'm going to close this one for now—I'm sorry that we couldn't get this in, but please feel free to resubmit this PR with translations for any languages that you personally know! |
Fixes #3274
Changes:
Added translation for t&c portion of the signup page
Description
"By signing up, you agree to the p5.js Editor's Terms of Use and Privacy Policy." This line in the signup page is translated to below-mentioned languages
Translated Languages
German - Deutsch
Spanish - Español
French - Français
Italian - Italiano
korean - 한국어
Portuguese - Português
Swedish - Svenska
Ukrainian - Українська
Urdu - اردو
Simplified Chinese - 简体中文
Traditional Chinese - 正體中文
All the translations are done using Google Translator and Cambridge Dictionary
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123