Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for user/pages folder #3307

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Rajnish2105
Copy link

Fixes #2923

Changes:
SignupView unit test
ResetPasswordView unit test
NewPassword unit test
LoginView unit test
EmailVerificationView unit test
AccountView unit test-9cases
Dashboard unit test
CollectionsView unit test

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Dec 24, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@dsaw
Copy link

dsaw commented Mar 8, 2025

This looks to be a nice start. I think there needs to be more discussion on the testing strategy and what the goals are.
Addressing questions like:

  1. What kind of unit tests will increase your confidence that the component is functional? testing existence of elements and its count is nice, are there any kind of tests depending on the component that might help with testing?
  2. Using data id locators is great, noticed you have used it in some places. When should is it preferable over role/label text locators?

And other questions would help guide the implementation better.
(Not a maintainer, just my thoughts).
any feedback @raclim ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Tests for Components in User Pages Folder
3 participants