Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed the todo - Divided the constants.js of redux into submodules #3311

Conversation

Vishawdeep-Singh
Copy link
Contributor

Completed TODO at the top of constants.js

Changes: I created a folder called “constants” and sub-modules of Redux constants, such as “fileActions.js”, “errorActions.js”, and so on. I then imported these sub-modules into the original “constants.js” file, spread them, and exported them.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Mar 6, 2025

Thanks so much for taking the time to work on this!

After giving it some thought, unfortunately I don't think we'll be able to go with this since we're hoping to migrate to using Redux Toolkit, which I believe eliminates the need for the constants.js folder. I'm sorry that we couldn't get this in, but if you'd like please feel free to jump in and continue the Redux Toolkit migration work that some folks have started!

@raclim raclim closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants