Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Dropdown/DropdownMenu.jsx with keyboard accessibility. #3313

Closed

Conversation

Rajnish2105
Copy link

Refactor -

  1. Updated DropdownMenu.jsx to allow keyboard access to the drop down.
  2. Made the component Generic instead of Wrapper.
  3. TabledropDown now accepts props like items (name, onclick, href, target, hideif) and aria-label.
  4. Update several component which used TabledropDown (styled DropdownMen) to send props to the component

Changes:
https://github.com/user-attachments/assets/d2be653a-6cbb-447b-87dd-dea62cc1c3c6

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Mar 6, 2025

Thanks so much for your work on this and for providing documentation of the feature!

Although this would be a great addition, after giving it some thought, unfortunately I don't think we'll be able to get this in since it conflicts with some of the work we're hoping to complete within the SketchList and DropdownMenu. I'm really sorry that we couldn't get this in, but please feel free to check out our other open issues! Otherwise, I think we could also try to keep working with your other PR that adds tests to the user pages.

@raclim raclim closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants