Jatin issue#3303 #3314
Jatin issue#3303 #3314
Conversation
The issue stemmed from the use of a setTimeout in the onBlur handler that closed the project options too quickly. Specifically, the setTimeout(() => dispatch(closeProjectOptions()), 0) was causing the options to close even if the user had not finished interacting with the menu. This was particularly problematic with trackpad input, where the timing of the events could be misinterpreted.
The issue stemmed from the use of a setTimeout in the onBlur handler that closed the project options too quickly. Specifically, the setTimeout(() => dispatch(closeProjectOptions()), 0) was causing the options to close even if the user had not finished interacting with the menu. This was particularly problematic with trackpad input, where the timing of the events could be misinterpreted.
|
@raclim, I fixed the test issues. Sorry for these— it is my old pull request, and I didn't focus on checking the tests earlier. |
There was a problem hiding this comment.
Thanks for taking a look into this!
I think the fix here might not be the best approach, as we probably want to keep setTimeout() to prevent the menu options from closing too soon and to ensure that the project options close after the action has been complete.
In the original issue, it links to another PR that probably was the cause, so I think trying to reset some of its changes and investing from there could be a start! I'm thinking that one approach could be to implement a useEffect() to handle open and closing the dropdown when the state of projectOptionsVisible changes, rather than using onBlur and onFocus to resolve both this issue and the one where the project options dropdown doesn't close when a user clicks outside of it.
|
@raclim i tried you Approach and it is actually much better than the OnBlur and Onfocus method Please review these again... ugh : ) |
Fixes #3303
Changes:
Removed of the setTimeout(() => dispatch(closeProjectOptions()), 0); allows the project options to remain open without prematurely closing when interacting with the menu, especially when using trackpads.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123