-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Login Page Translation Error: "Invalid Username or Password" #3340
base: develop
Are you sure you want to change the base?
Conversation
i Just Add the Translation for the backend Error response in Each language to fix these issue and a translateSubmitError.
Thanks for submitting this! Since there's a lot of languages here on this pull request, I wanted to go over some options where this could go!
I personally feel that it might be better to go with the second option is possible, but let me know which sounds better to you or if you have any other suggestions, thanks! |
@raclim I appreciate the review! I’ve carefully verified these translations using a dictionary and also took input from my connections on social media and friends who speak these languages. While I understand the need for review, I believe the translations are accurate and good to go. If I were to submit a PR only for the languages I personally speak (English, Hindi, French, Bengali), it might lead to new issues about missing translations, which could cause more fragmentation and maintenance overhead for the organization. That said, I’m happy to wait for additional reviews if needed. Let me know how you'd like to proceed! |
@raclim should i make changes ?? |
@raclim I have checked this PR, and I can assure you that the translations for English, Hindi, French, Portuguese, and Korean are correct, as I know only these languages. |
After giving it some thought on how we want to handle translations, I think we might want to move away from accepting large submissions with a lot of different languages, and gear towards 1-2 languages per submission. Ideally, the 1-2 languages should be ones that the contributor should know and speak natively to ensure that we're getting proper translations. The reason for this shift is that I feel that we should encourage moving away from machine translations, and to have PRs be as ready for submission as possible. Although having multiple PRs for a translation might feel fragmented, I think this approach feels steadier and helps with reviewing and organization. Would you be able to update this PR to only include the languages that you speak? |
Got it! That makes sense. I'll update the PR to include only the languages I speak and remove the rest. |
@raclim take a look again. Is there is anything else i should? |
ughh ... By mistake i just closed it |
i Just Add the Translation for the backend Error response in Each language to fix these issue and a translateSubmitError.
Progress towards #issue-#3339
Changes:
i Just Add the Translation for the backend Error response in Each language to fix these issue and a translateSubmitError.
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123