Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Login Page Translation Error: "Invalid Username or Password" #3340

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Jatin24062005
Copy link
Contributor

@Jatin24062005 Jatin24062005 commented Feb 10, 2025

i Just Add the Translation for the backend Error response in Each language to fix these issue and a translateSubmitError.

Progress towards #issue-#3339

Changes:
i Just Add the Translation for the backend Error response in Each language to fix these issue and a translateSubmitError.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

i Just Add the Translation for the backend Error response in Each language to fix these issue and a translateSubmitError.
@raclim
Copy link
Collaborator

raclim commented Feb 20, 2025

Thanks for submitting this!

Since there's a lot of languages here on this pull request, I wanted to go over some options where this could go!

  • Option 1: I think I might've noted this already on the associated issue or other translation PRs, but since we try not to rely solely on machine translations and have incoming translations vetted by native speakers before merging them in, we can keep this PR open and add a "Help Wanted" tag to try to get more native speaker's eyes on this. If we go this route, we should update the description for this PR with a list of the languages that this includes, and potentially think of how to get more eyes on this. This process would definitely take a while!

  • Option 2: Another option is to adjust this PR to only translate the languages that you may speak. We can still create a list of missing translations and add it to the original issue to inform incoming contributors. This approach also lets us merge in the new translations in chunks rather than all at once!

I personally feel that it might be better to go with the second option is possible, but let me know which sounds better to you or if you have any other suggestions, thanks!

@Jatin24062005
Copy link
Contributor Author

@raclim I appreciate the review! I’ve carefully verified these translations using a dictionary and also took input from my connections on social media and friends who speak these languages. While I understand the need for review, I believe the translations are accurate and good to go.

If I were to submit a PR only for the languages I personally speak (English, Hindi, French, Bengali), it might lead to new issues about missing translations, which could cause more fragmentation and maintenance overhead for the organization.

That said, I’m happy to wait for additional reviews if needed. Let me know how you'd like to proceed!

@Jatin24062005
Copy link
Contributor Author

@raclim should i make changes ??

@Harshit-7373
Copy link
Contributor

@raclim I have checked this PR, and I can assure you that the translations for English, Hindi, French, Portuguese, and Korean are correct, as I know only these languages.

@raclim
Copy link
Collaborator

raclim commented Mar 6, 2025

After giving it some thought on how we want to handle translations, I think we might want to move away from accepting large submissions with a lot of different languages, and gear towards 1-2 languages per submission. Ideally, the 1-2 languages should be ones that the contributor should know and speak natively to ensure that we're getting proper translations. The reason for this shift is that I feel that we should encourage moving away from machine translations, and to have PRs be as ready for submission as possible.

Although having multiple PRs for a translation might feel fragmented, I think this approach feels steadier and helps with reviewing and organization. Would you be able to update this PR to only include the languages that you speak?

@Jatin24062005
Copy link
Contributor Author

Got it! That makes sense. I'll update the PR to include only the languages I speak and remove the rest.

@Jatin24062005
Copy link
Contributor Author

@raclim take a look again. Is there is anything else i should?

@Jatin24062005
Copy link
Contributor Author

ughh ... By mistake i just closed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants