Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Error Regarding Email Verification and Added Telugu translations #3351

Closed

Conversation

thunish
Copy link

@thunish thunish commented Feb 25, 2025

Fixes #issue-number #3349

Modified locale files to ensure there are no translation errors related to the "Email Verification Link Failed" message.

Added Telugu (te) translations to the project.

Copy link

welcome bot commented Feb 25, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@Jatin24062005
Copy link
Contributor

Hey @thunish,

I reviewed your pull request and noticed that you added a new language that doesn’t seem necessary. Could you please remove it and make changes only to the languages you actively use? This would ensure a more efficient and relevant update for the organization.

Or, you may wait until all languages have been reviewed.

@raclim
Copy link
Collaborator

raclim commented Mar 6, 2025

After giving it some thought on how we want to handle translations, I think we might want to move away from accepting large submissions with a lot of different languages, and gear towards 1-2 languages per submission. Ideally, the 1-2 languages should be ones that the contributor should know and speak natively to ensure that we're getting proper translations. The reason for this shift is that I feel that we should encourage moving away from machine translations, and to have PRs be as ready for submission as possible.

I'm going to close this one for now—I'm sorry that we couldn't get this in, but please feel free to resubmit this PR with translations for any languages that you personally know!

@raclim raclim closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants