Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing All the Test inside Docker. #3353

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

Jatin24062005
Copy link
Contributor

@Jatin24062005 Jatin24062005 commented Mar 1, 2025

Fixes #issue-3280 , #3190 & some mentioned Issues also

Changes:

I thoroughly analyzed the functionality and architecture of the test setup and found that the primary issue was related to React rendering. However, all the necessary plugins were already pre-installed.

To resolve the issue, I made the following changes:

Updated the NODE_ENV to either test or production, ensuring compatibility with the testing environment.
Manually modified certain files, including Nav.unit.test.jsx.snap, to align with the expected test output.
Installed additional required packages to support the testing framework

Screenshot:
image

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com release-com bot deployed to p5.js-web-editor: rachel-jatin-issue-#3280 (tedb983) March 6, 2025 13:15 Active
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this! I think this seems to work well for me!

@raclim raclim merged commit a8dbd59 into processing:develop Mar 6, 2025
3 checks passed
@Jatin24062005
Copy link
Contributor Author

Most welcome, @raclim! This fix was much needed. Glad to see it merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants