-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Load Function to Accept a callback without triggering a warning #7551
base: main
Are you sure you want to change the base?
Fix Load Function to Accept a callback without triggering a warning #7551
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Hey @Jatin24062005, rather than making a special case for fonts here, are we able to update the doc comments for |
Hey @davepagurek ! I saw that @limzykenneth mentioned some contributors are already working on the documentation. Should I still proceed with updating the doc comments for loadFont(), or would it be better to coordinate with them to avoid duplicate efforts? |
If you're still up for working on it, we can just make sure @GregStanton and @perminder-17 know you're working on this one! |
@davepagurek I believe @GregStanton and @perminder-17 might be a better fit for handling the documentation updates, as they have more experience in this area. I haven’t worked much with graphics, which makes me a bit less confident in making the necessary changes. |
Hi @Jatin24062005! Thanks so much for your help! @davepagurek: Do you think you'd be able to offer @Jatin24062005 some help here? Otherwise, just ping me, and I'll do my best to help. I'll just need to familiarize myself with this feature a bit more before I do. |
Hey, sorry for the delay! I think what we need to do here is add a doc comment above Line 539 in e37bfa6
A similar example for p5.js/src/image/loading_displaying.js Lines 40 to 47 in e37bfa6
The square brackets around a parameter name indicates that it's optional. |
Resolves #7541
Changes:
Allow loadFont() to accept a callback without triggering a warning by adding up the condition statement. which checks the load function arguments and the function
PR Checklist
npm run lint
passes