Fix camera tilt function to prevent orientation flipping #7598
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepagurek
reviewed
Mar 7, 2025
There was a problem hiding this comment.
Thanks for taking this on, I think your approach looks good! Two things before merging:
- Since the pan/tilt/etc functions have been a tad buggy in the past, do you think we can add a unit test to check the result of the up vector after a tilt?
- Like your other recent PR, I assume this applies to p5 2.0 as well. Once this one is ready, could you also make a second PR into the
dev-2.0branch?
| @@ -2448,17 +2448,33 @@ p5.Camera = class Camera { | |||
| rotatedCenter[1] += this.eyeY; | |||
| rotatedCenter[2] += this.eyeZ; | |||
|
|
|||
| // Compute new up vector to prevent flipping | |||
| let forward = createVector( | |||
There was a problem hiding this comment.
The global createVector function isn't available in instance mode, can we import the vector class directly and do new Vector(...) here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7377
Changes:
p5.Camera.tilt()did not update the up vector.Screenshots of the change:
PR Checklist
npm run lintpasses