Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include processing4-javafx in Gradle packaging #941

Open
micycle1 opened this issue Feb 3, 2025 · 4 comments
Open

Include processing4-javafx in Gradle packaging #941

micycle1 opened this issue Feb 3, 2025 · 4 comments
Labels
core enhancement New feature or request

Comments

@micycle1
Copy link

micycle1 commented Feb 3, 2025

@Stefterv

I think you should consider bundling processing4-javafx with the processing core gradle artifact (as I do in https://github.com/micycle1/processing-core-4/)

Otherwise one cannot use the FX2D renderer.

Also, why must I as a user declare the https://jogamp.org/ repository for jogl? Shouldn't this artifact's gradle do that?

@Stefterv Stefterv added enhancement New feature or request core labels Feb 3, 2025
@Stefterv
Copy link
Collaborator

Stefterv commented Feb 3, 2025

Hi @micycle1!

I will, do you think it would also work as a seperate package? I'm more inclined to head in that direction.

Re: the jogamp repo, completely agree, I hadn't found a way to do that but have to admit I didn't look to deep into it either

@Stefterv
Copy link
Collaborator

Stefterv commented Feb 3, 2025

Reading the Sonatype Documentation:
https://central.sonatype.org/publish/requirements/#a-complete-example-pom
"We discourage the usage of <repositories> and <pluginRepositories>, instead publish any required components to the Central Repository. This applies for your own components as well as for 3rd party artifacts." I'm not sure what would happen if we try to publish with the repositories linked but maybe we would need to upload the JOGL artifacts too

@micycle1
Copy link
Author

micycle1 commented Feb 3, 2025

A separate package is probably best, but if it's then added as dependency to core, circularity is introduced (since fx package uses PSurface etc).

(Alternatively, let user specify when they want FX and don't add as dependency to core).

@micycle1
Copy link
Author

micycle1 commented Feb 3, 2025

"Discourage" would imply it works, but not according their best practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants