Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Contextmanagers to handle StopIteration in generators #12934

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

RonnyPfannschmidt
Copy link
Member

  • prepare example test for stopiteration passover issue
  • WIP: use contextmanagers instead of yield from

yield from is a generator boundary that transfers StopIteration into a RuntimeError

closes #12929

as it turns out, StopIteration is not transparent on the boundaries of generators
@RonnyPfannschmidt RonnyPfannschmidt added this to the 8.4 milestone Nov 12, 2024
@graingert
Copy link
Member

graingert commented Dec 9, 2024

src/_pytest/threadexception.py and src/_pytest/unraisableexception.py both use regular trylast hooks instead of generators, so the conflicts can be resolved by checking them out from main

@graingert
Copy link
Member

this won't pass without a new Pluggy release

@nicoddemus
Copy link
Member

@RonnyPfannschmidt what is the status here? Do you plan to make a pluggy release yourself?

@RonnyPfannschmidt
Copy link
Member Author

Indeed

I intend to give this priority by the end of the month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests raising StopIteration break pytest/pluggy
4 participants