Update rm_rf function to force remove directories #13270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13269
In previous
rm_rf
function Usesshutil.rmtree(path, onerror=onerror)
, which recursively deletes everything, handling errors via onerror.Now i update the
rm_rf
function to Explicitly walks the directory tree bottom-up(topdown=False)
and removes files first, then subdirectories before deleting the main directory.Now there are no more warnings after passing all tests.