-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace check.sh and/or ci.sh with tox/nox #3170
Comments
Reopening #3196 because it says that it's not enough right in the first sentence.. It's the |
followup from #3196 (comment): remove quotes from descriptions |
And the descriptions can be multi-line + contain substitutions like |
Another follow-up (#3196 (comment)): call tox from RTD. Example: https://github.com/ansible/awx-plugins/blob/b90483b/.readthedocs.yaml + https://github.com/ansible/awx-plugins/blob/b90483b/tox.ini#L372C7-L372C53. |
And another one (#3196 (comment)): separate tox invocation into installing the deps and running the (test) commands. Example: https://github.com/ansible/awx-plugins/blob/b90483b/.github/workflows/reusable-tox.yml#L288-L301 ( Bonus points for an additional tox invocation with maximum verbosity, rerunning the failed tests, also with maximum verbosity of pytest: https://github.com/ansible/awx-plugins/blob/b90483b/.github/workflows/reusable-tox.yml#L366-L382 + https://github.com/ansible/awx-plugins/blob/b90483b/.github/workflows/ci-cd.yml#L699-L702. |
Originally posted by @webknjaz in #3157 (comment)
thread contains more discussion on tox vs nox. Whoever wants to Do It can probably just decide on either.
Initial PR does not need to be a huge one that replaces all of check.sh & ci.sh and overhauls CI stuff, an incremental approach should work perfectly fine here.
The text was updated successfully, but these errors were encountered: