Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tkinter missing -nolinestop on tk.Text #130693

Open
r4ph43l-glitch opened this issue Feb 28, 2025 · 3 comments · May be fixed by #130848
Open

tkinter missing -nolinestop on tk.Text #130693

r4ph43l-glitch opened this issue Feb 28, 2025 · 3 comments · May be fixed by #130848
Labels
stdlib Python modules in the Lib dir topic-tkinter type-feature A feature request or enhancement

Comments

@r4ph43l-glitch
Copy link

r4ph43l-glitch commented Feb 28, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

# current tkinter/__init__.py

class Text(...):
[...]
    def search(self, pattern, index, stopindex=None,
           forwards=None, backwards=None, exact=None,
           regexp=None, nocase=None, count=None, elide=None):
[...]

The current tkinter implementation of the tkinter.Text.search method misses use of tcl options:
-nolinestop
-all
-overlap
-strictlimits

Is there any reason on why it is not inside the CPython implementation?

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs
@r4ph43l-glitch r4ph43l-glitch added the type-bug An unexpected behavior, bug, or error label Feb 28, 2025
@picnixz picnixz added type-feature A feature request or enhancement stdlib Python modules in the Lib dir topic-tkinter and removed type-bug An unexpected behavior, bug, or error labels Feb 28, 2025
@sharktide
Copy link

I'll see if I can make a pr

@sharktide
Copy link

Almost done, I have to write unittests.

@sharktide
Copy link

is currently avalible at https://github.com/sharktide/cpython/tree/patch-130693

@sharktide sharktide linked a pull request Mar 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir topic-tkinter type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
3 participants
@picnixz @sharktide @r4ph43l-glitch