Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-130794: Process interpreter QSBR queue in _PyMem_AbandonDelayed. #130808

Merged
merged 3 commits into from
Mar 4, 2025
Merged

gh-130794: Process interpreter QSBR queue in _PyMem_AbandonDelayed. #130808

merged 3 commits into from
Mar 4, 2025

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 3, 2025 •
edited by bedevere-app bot
Loading

This avoids a case where the interpreter's queue of memory to be freed could grow rapidly if there are many short lived threads.

@colesbury
pythongh-130794: Process interpreter QSBR queue in _PyMem_AbandonDela…
15bd961 
…yed.

This avoids a case where the interpreter's queue of memory to be freed
could grow rapidly if there are many short lived threads.
@colesbury colesbury requested a review from DinoV March 3, 2025 20:37
@bedevere-app bedevere-app bot mentioned this pull request Mar 3, 2025
Open
DinoV
DinoV approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colesbury colesbury merged commit 2f6e0e9 into python:main Mar 4, 2025
46 checks passed
@colesbury colesbury deleted the gh-130794-process-queue branch March 4, 2025 23:04
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2f6e0e9f7001769be746ee96356656d3ebdc7f96 3.13

@bedevere-app
Copy link

bedevere-app bot commented Mar 4, 2025

GH-130857 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 4, 2025
colesbury added a commit to colesbury/cpython that referenced this pull request Mar 4, 2025
@colesbury
[3.13] pythongh-130794: Process interpreter QSBR queue in _PyMem_Aban…
baba972 
…donDelayed. (pythongh-130808)

This avoids a case where the interpreter's queue of memory to be freed
could grow rapidly if there are many short lived threads.
(cherry picked from commit 2f6e0e9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit that referenced this pull request Mar 4, 2025
@colesbury
[3.13] gh-130794: Process interpreter QSBR queue in _PyMem_AbandonDel…
0752275 
…ayed. (gh-130808) (#130857)

This avoids a case where the interpreter's queue of memory to be freed
could grow rapidly if there are many short lived threads.
(cherry picked from commit 2f6e0e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinoV DinoV

Assignees

@colesbury colesbury

Labels
topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @DinoV