-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-130814: Enhance documentation for Python C API type objects #130817
base: main
Are you sure you want to change the base?
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not particularly convinced we need this, but perhaps it's worth considering. cc @picnixz--do you think there's any added clarity here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this, we skip blurb entries for documentation changes--the "Documentation" section is for changes to the docs build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I get rid of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@picnixz (Sorry, I'm not sure why the tag didn't work the first time.) |
If It helps here is the documentation preview: The changed page is to add clarity since there are two pages with different content with the same title: The other page with the same title is this |
I'm not sure I'll have time for review today. And I'm leaving for 10 days so I won't be back until the mid/end of next week |
@ZeroIntensity You tagged @picnixz--do as it isn't smart enough to split it. (I've made this mistake before too :-) |
@sharktide You do not need to update the branch (This should be made more clear in the devguide) |
ok |
Update from
Type Objects ============
to
Type Object Structures ======================
Based on issue #130814