gh-130819: Update tarfile.py#_create_gnu_long_header to align with GNU Tar
#130820
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
gdh1995
force-pushed
the
fix_long_gnu_name_in_tarfile
branch
from
ce2e670 to
24b90cf
Compare
Misc/NEWS.d/next/Library/2025-03-04-03-14-44.gh-issue-130819.Dphgb6.rst
Outdated
Show resolved
Hide resolved
gdh1995
force-pushed
the
fix_long_gnu_name_in_tarfile
branch
from
24b90cf to
283b34e
Compare
There was a problem hiding this comment.
Can you motivate the choice for this? namely is there a real benefit between having an explicit user+mode rather than letting the "defaults"? And more importantly, can you cite the relevant manpage / specs where we can find this?
Note: whether this is accpeted or not, this should be treated as a feature request and not a bug IMO. As such, a What's New entry will need to be created, unless the motivation behind this change is not sufficient (in which case we would close the issue as "not planned")
| info["mode"] = 0o100644 | ||
| info["uname"] = "root" | ||
| info["gname"] = "root" |
There was a problem hiding this comment.
Where in the specs are these decided?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Oh btw, please reply on the issue instead of the PR (I'll repost my comment above) |
The latest
tarfilemay still generate a file slightly different with the one made by GNU Tar, whenever a path name is longer than 100 bytes. So this PR tries to avoid the difference.More details are in #130819 .