gh-130827: Support typing.Self annotations in singledispatchmethod()
#130829
Conversation
ZeroIntensity
added
topic-typing
needs backport to 3.12
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
| # But, it shouldn't work on singledispatch() | ||
| with self.assertRaises(TypeError): | ||
| @test.register | ||
| def silly(self: typing.Self, arg: int | str) -> int | str: |
There was a problem hiding this comment.
Will 'typing.Self' annotation work the same way?
There was a problem hiding this comment.
Good question! It should, yeah. get_type_hints handles forward references.
There was a problem hiding this comment.
Should we add a test case for that, maybe?
There was a problem hiding this comment.
Possibly, but as long as get_type_hints is working it's probably fine.
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
| "typing.Self can only be used with singledispatchmethod()" | ||
| ) | ||
| else: | ||
| argname, cls = next(hints_iter) |
There was a problem hiding this comment.
This seems like it will behave incorrectly if a parameter that is not self is annotated with Self.
There was a problem hiding this comment.
Sorry for dropping the ball here--good catch. What's the best way to deal with that? Just some extra sanity checks to somehow make sure that a Self is the first parameter?
There was a problem hiding this comment.
I don't know, maybe we should unconditionally ignore the type hint on the self parameter? Not too familiar with how singledispatchmethod works.
singledispatchmethod.registerfails withtyping.Selfannotation #130827