-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128041: Add terminate_workers
and kill_workers
methods to ProcessPoolExecutor
#130849
Conversation
…o ProcessPoolExecutor Add some fixes to tests to make them no longer transient
🤖 New build scheduled with the buildbot fleet by @gpshead for commit ec7599c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
I've run
75 times in a row now without a failure. @colesbury mind checking again. Thanks for the feedback! |
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 92a2d72 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @csm10495, this looks good to me!
I rescheduled the buildbots and I'm also running some stress tests locally. So far, it looks good!
I don't think those buildbot failures are related, but not 100% sure. |
Provides a way to forcefully stop all the workers in the pool
Typically this would be used as a last effort to stop all workers if unable to shutdown / join in the expected way.
This is a newer version of #128043 that includes fixes for transient issues seen in CI.
terminate_workers
toProcessPoolExecutor
#128041📚 Documentation preview 📚: https://cpython-previews--130849.org.readthedocs.build/