Add flag to allow more flexible variable redefinition #18727

JukkaL · 2025-02-24T14:17:46Z

Infer union types for simple variables from multiple assignments, if the variable isn't annotated. The feature is enabled via --allow-redefinition-new. --local-partial-types must also be enabled.

This is still experimental and has known issues, so it's not documented anywhere. It works well enough that it can be used for non-trivial experimentation, however.

Closes #6233. Closes #6232. Closes #18568. Fixes #18619.

In this example, the type of x is inferred as int | str when using the new behavior:

def f(i: int, s : str) -> int | str:
    if i > 5:
        x = i
    else:
        x = s  # No longer an error
    reveal_type(x)  # int | str
    return s

Here is a summary of how it works:

Assignment widens the inferred type of a variable and always narrows (when there is no annotation).
Simple variable lvalues are put into the binder on initial assignment when using the new feature. We need to be able to track whether a variable is defined or not to infer correct types (see Binder loses narrowed type of a variable if variable may be uninitialized #18619).
Assignment of None values are no longer special, and we don't use partial None if the feature is enabled for simple variables.
Lvalues other than simple variables (e.g. self.x) continue to work as in the past. Attribute types can't be widened, since they are externally visible and widening could cause confusion, but this is something we might relax in the future. Globals can be widened, however. This seems necessary for consistency.
If a loop body widens a variable type, we have to analyze the body again. However, we only do one extra pass, since the inferred type could be expanded without bound (consider x = 0 outside loop and x = [x] within the loop body).
We first infer the type of an rvalue without using the lvalue type as context, as otherwise the type context would often prevent redefinition. If the rvalue type isn't valid for inference (e.g. list item type can't be inferred), we fall back to the lvalue type context.

There are some other known bugs and limitations:

Annotated variables can't be freely redefined (but they can still be narrowed, of course). I may want to relax this in the future, but I'm not sure yet.
If there is a function definition between assignments to a variable, the inferred types may be incorrect.
There are few tests for nonlocal and some other features. We don't have good test coverage for deferrals, mypy daemon, and disabling strict optional.
Imported names can't be redefined in a consistent way. This needs further analysis.

In self check the feature generates 6 additional errors, which all seem correct -- we infer more precise types, which will generate additional errors due to invariant containers and fixing false negatives.

When type checking the largest internal codebase at Dropbox, this generated about 700 new errors, the vast majority of which seemed legitimate. Mostly they were due to inferring more precise types for variables that used to have Any types. I used a recent but not the latest version of the feature to type check the internal codebase.

…ontext

cdce8p · 2025-02-26T12:52:36Z

Got an error when testing the branch with Home Assistant.

Error: /.../python3.13/site-packages/azure/servicebus/management/_generated/_serialization.py:655: error: INTERNAL ERROR
version: 1.16.0+dev.5bd6defcc6e2eb0f47e59f4bee35a51db5a27725
/.../python3.13/site-packages/azure/servicebus/management/_generated/_serialization.py:655: : note: use --pdb to drop into pdb
Traceback (most recent call last):
  File "mypy/checker.py", line 580, in accept
  File "mypy/nodes.py", line 1462, in accept
  File "mypy/checker.py", line 5263, in visit_for_stmt
  File "mypy/checker.py", line 629, in accept_loop
RuntimeError: Too many iterations when checking a loop

It seems to fail when checking azure-servicebus and in particular this function with the Home Assistant mypy config: https://github.com/Azure/azure-sdk-for-python/blob/azure-servicebus_7.10.0/sdk/servicebus/azure-servicebus/azure/servicebus/management/_generated/_serialization.py#L568

Was able to narrow it down to this

# mypy: local-partial-types, allow-redefinition-new, show-traceback
from typing import Any
def func() -> Any: ...

def serialize() -> Any:
    for _ in range(10):
        keys = func()
        new_attr = func()

        for k in reversed(keys):
            new_attr = {k: new_attr}

reveal_type(1)

Full traceback

$ mypy test.py 
test.py:10: error: INTERNAL ERROR
version: 1.16.0+dev.5bd6defcc6e2eb0f47e59f4bee35a51db5a27725
Traceback (most recent call last):
  File ".../venv/bin/mypy", line 8, in <module>
    sys.exit(console_entry())
  File ".../mypy/__main__.py", line 15, in console_entry
    main()
  File ".../mypy/main.py", line 126, in main
    res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)
  File ".../mypy/main.py", line 210, in run_build
    res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)
  File ".../mypy/build.py", line 191, in build
    result = _build(
  File ".../mypy/build.py", line 267, in _build
    graph = dispatch(sources, manager, stdout)
  File ".../mypy/build.py", line 2939, in dispatch
    process_graph(graph, manager)
  File ".../mypy/build.py", line 3337, in process_graph
    process_stale_scc(graph, scc, manager)
  File ".../mypy/build.py", line 3438, in process_stale_scc
    graph[id].type_check_first_pass()
  File ".../mypy/build.py", line 2311, in type_check_first_pass
    self.type_checker().check_first_pass()
  File ".../mypy/checker.py", line 473, in check_first_pass
    self.accept(d)
  File ".../mypy/checker.py", line 580, in accept
    stmt.accept(self)
  File ".../mypy/nodes.py", line 813, in accept
    return visitor.visit_func_def(self)
  File ".../mypy/checker.py", line 1097, in visit_func_def
    self._visit_func_def(defn)
  File ".../mypy/checker.py", line 1101, in _visit_func_def
    self.check_func_item(defn, name=defn.name)
  File ".../mypy/checker.py", line 1135, in check_func_item
    self.check_func_def(defn, typ, name, allow_empty)
  File ".../mypy/checker.py", line 1422, in check_func_def
    self.accept(item.body)
  File ".../mypy/checker.py", line 580, in accept
    stmt.accept(self)
  File ".../mypy/nodes.py", line 1281, in accept
    return visitor.visit_block(self)
  File ".../mypy/checker.py", line 3091, in visit_block
    self.accept(s)
  File ".../mypy/checker.py", line 580, in accept
    stmt.accept(self)
  File ".../mypy/nodes.py", line 1462, in accept
    return visitor.visit_for_stmt(self)
  File ".../mypy/checker.py", line 5263, in visit_for_stmt
    self.accept_loop(
  File ".../mypy/checker.py", line 616, in accept_loop
    self.accept(body)
  File ".../mypy/checker.py", line 580, in accept
    stmt.accept(self)
  File ".../mypy/nodes.py", line 1281, in accept
    return visitor.visit_block(self)
  File ".../mypy/checker.py", line 3091, in visit_block
    self.accept(s)
  File ".../mypy/checker.py", line 580, in accept
    stmt.accept(self)
    ~~~~~~~~~~~^^^^^^
  File ".../mypy/nodes.py", line 1462, in accept
    return visitor.visit_for_stmt(self)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File ".../mypy/checker.py", line 5263, in visit_for_stmt
    self.accept_loop(
    ~~~~~~~~~~~~~~~~^
        s.body,
        ^^^^^^^
    ...<3 lines>...
        ),
        ^^
    )
    ^
  File ".../mypy/checker.py", line 629, in accept_loop
    raise RuntimeError("Too many iterations when checking a loop")
RuntimeError: Too many iterations when checking a loop

JukkaL · 2025-02-26T15:36:58Z

Yeah, looks like something is wrong with nested loops. Simplified the reproducer to this:

# mypy: local-partial-types, allow-redefinition-new

def a(): ...

def f() -> None:
    while int():
        x = a()

        while int():
            x = [x]

github-actions · 2025-02-27T11:59:55Z

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

cdce8p · 2025-02-27T19:26:20Z

Check Home Assistant again. The run now completes with 59 new errors. Most are either true-positives or can be resolved quite easily by adding an explicit type annotation. Noticed two cases which might require more attention

# mypy: local-partial-types, allow-redefinition-new, allow-empty-bodies

def func() -> None:
    l = None

    if int():
        l = []
        l.append(1)  # fine -> error 'Argument 1 to "append" of "list" has incompatible type "int"; expected "Never"'

This one came up quite a lot actually. Yes, it would be possible to resolve it by annotating l with list[Any] | None. However, if possible, I think it would be better if mypy was able to resolve it to list[Any] itself.

For the second example, I'm not really sure what's going on. After the if, x get's narrowed even though there wasn't any assignment. This only seems to happen with tuple unpacking.

# mypy: local-partial-types, allow-redefinition-new, allow-empty-bodies
from typing import Any
def get_details() -> tuple[Any, Any] | tuple[None, None]: ...

def func2() -> None:
    x, _ = get_details()
    reveal_type(x)
    if x and int():
        ...
    reveal_type(x)   # Any | None -> None  # ??
    if x and int():  # fine -> error 'Right operand of "and" is never evaluated'
        ...

A5rocks · 2025-02-28T00:49:41Z

When running over trio, I found another issue:

def blah() -> tuple[int]:
    return (42,)

def main() -> None:
    x, *_ = blah()  # E: Need type annotation for "_" (hint: "_: list[<type>] = ...")

(note that if the main function isn't there then the error happens without this PR. Not sure what's happening)

hauntsaninja · 2025-02-28T00:50:54Z

Could be worth enabling it by default temporarily in this PR to see if mypy_primer surfaces stuff?

ilevkivskyi · 2025-02-28T09:07:53Z

Could be worth enabling it by default temporarily in this PR to see if mypy_primer surfaces stuff?

I would strongly recommend this as well. It was really helpful e.g. when I worked on new inference. I will try to look at this PR soon (even before others in my queue).

In the meantime, the second example posted by @cdce8p is because binder has special logic for multi-assign from union. It doesn't put immediately, but instead accumulates assignments, and later puts them together, see e.g. accumulate_type_assignments().

ilevkivskyi · 2025-03-05T23:12:37Z

Most likely this is because this PR somehow breaks logic for overrides with custom properties (i.e. those where setter has different type).

jorenham · 2025-03-05T23:27:02Z

Most likely this is because this PR somehow breaks logic for overrides with custom properties (i.e. those where setter has different type).

That makes sense. And to be fair, it's a rather sneaky thing that I'm doing there, so I suppose you could consider it as a stress-test.

ilevkivskyi

Finally had time to look at this. I think the approach looks very promising. I left a bunch of comments but they are minor. As it was proposed before I suggest again to run against mypy_primer with the flag set to True to get better idea of impact.

ilevkivskyi · 2025-03-06T22:48:59Z

mypy/binder.py

@@ -226,12 +233,15 @@ def update_from_options(self, frames: list[Frame]) -> bool:
        for key in keys:
            current_value = self._get(key)
            resulting_values = [f.types.get(key, current_value) for f in frames]
-            if any(x is None for x in resulting_values):
+            old_semantics = not self.bind_all or extract_var_from_literal_hash(key) is None


This is quite tricky and with time we may forget what old_semantics mean. I think it is worth adding a comment with motivating code example here.

ilevkivskyi · 2025-03-06T22:52:45Z

mypy/checker.py

@@ -316,6 +316,8 @@ class TypeChecker(NodeVisitor[None], CheckerPluginInterface):
    # Vars for which partial type errors are already reported
    # (to avoid logically duplicate errors with different error context).
    partial_reported: set[Var]
+    # Short names of Var nodes whose previous inferred type has been widened via assignment
+    widened_vars: list[str]


IIUC this is only used to track updates in a loop. If so, can this be replaced with a counter, or even a boolean flag? Otherwise people may accidentally start using this for something else, and short names are fragile w.r.t. name clashes.

ilevkivskyi · 2025-03-06T22:54:28Z

mypy/checker.py

+                if (
+                    (partials_new == partials_old)
+                    and (not self.binder.last_pop_changed or iter > 3)
+                    and (widened_new == widened_old or iter > 1)


FMI, why these numbers (1 vs 3) are different? They look quite arbitrary.

ilevkivskyi · 2025-03-06T22:58:36Z

mypy/checker.py

+                        if v.type is not None:
+                            n = NameExpr(v.name)
+                            n.node = v
+                            self.binder.assign_type(n, v.type, v.type)


Would it be possible to use .put() here? Or is the TODO above about this? (If yes, it is not obvious there)

ilevkivskyi · 2025-03-06T23:03:42Z

mypy/checker.py

@@ -3286,7 +3317,10 @@ def check_assignment(
                            lvalue_type = make_optional_type(lvalue_type)
                            self.set_inferred_type(lvalue.node, lvalue, lvalue_type)


IIUC this is old special-casing for inferring optional types from assignments in if statements. Shouldn't we make this conditional on new redefinition flag being False?

ilevkivskyi · 2025-03-06T23:17:41Z

mypy/checker.py

+                                new_type = DeletedType(source=source)
+                                var.node.type = new_type
+                                if self.options.allow_redefinition_new:
+                                    self.binder.assign_type(var, new_type, new_type)


Not sure I fully understand the logic here. But again, it seems .put() may be used here.

ilevkivskyi · 2025-03-06T23:26:13Z

test-data/unit/check-redefine2.test

+reveal_type(C4().x) # N: Revealed type is "builtins.list[builtins.str]"
+[builtins fixtures/list.pyi]
+
+[case testZZZ]


Not sure what this test is doing here (also it doesn't set new flag).

ilevkivskyi · 2025-03-06T23:28:41Z

test-data/unit/check-redefine2.test

+    except Exception:
+        # TODO: Too wide
+        reveal_type(x) # N: Revealed type is "Union[builtins.int, builtins.str]"
+    # TODO: Too wide


Is this problem specific to try/except? If yes, it is fine to leave it for a follow-up PR.

ilevkivskyi · 2025-03-06T23:32:04Z

test-data/unit/check-redefine2.test

+        reveal_type(x) # N: Revealed type is "builtins.int"
+    else:
+        x = ''
+        reveal_type(x) # N: Revealed type is "builtins.str"


Maybe my missed them, but I think it is important to add tests with deeper (like 2-level and maybe even 3-level) nesting of if statements, checking the revealed type on exiting each nesting level.

ilevkivskyi · 2025-03-06T23:34:23Z

mypy/checker.py

+                            self.widened_vars.append(inferred.name)
+                            self.set_inferred_type(inferred, lvalue, lvalue_type)
+                            self.binder.put(lvalue, rvalue_type)
+                            # TODO: hack, maybe integrate into put?


FWIW I am not sure why integrating the update of declaration into .put() would be better.

jorenham · 2025-03-07T11:26:14Z

I just tried running this on the (new) numpy stubs in numpy/numtype on the current main branch (3e9fc75). But hen I run it with uv run --no-editable mypy --tb src, I see the following:

      Built numtype @ file:///projects/numtype
Uninstalled 1 package in 0.40ms
Installed 1 package in 2ms
src/numpy-stubs/ma/core.pyi:308: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.16.0+dev.3e38e7d24ec06675d5b8b8df0b18c2e25d62f3c6
Traceback (most recent call last):
  File "/projects/numtype/.venv/bin/mypy", line 10, in <module>
    sys.exit(console_entry())
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/__main__.py", line 15, in console_entry
    main()
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/main.py", line 126, in main
    res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/main.py", line 210, in run_build
    res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/build.py", line 191, in build
    result = _build(
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/build.py", line 267, in _build
    graph = dispatch(sources, manager, stdout)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/build.py", line 2939, in dispatch
    process_graph(graph, manager)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/build.py", line 3337, in process_graph
    process_stale_scc(graph, scc, manager)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/build.py", line 3438, in process_stale_scc
    graph[id].type_check_first_pass()
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/build.py", line 2311, in type_check_first_pass
    self.type_checker().check_first_pass()
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 473, in check_first_pass
    self.accept(d)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 580, in accept
    stmt.accept(self)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/nodes.py", line 1200, in accept
    return visitor.visit_class_def(self)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 2597, in visit_class_def
    self.accept(defn.defs)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 580, in accept
    stmt.accept(self)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/nodes.py", line 1281, in accept
    return visitor.visit_block(self)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 3091, in visit_block
    self.accept(s)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 580, in accept
    stmt.accept(self)
    ~~~~~~~~~~~^^^^^^
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/nodes.py", line 580, in accept
    return visitor.visit_overloaded_func_def(self)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 659, in visit_overloaded_func_def
    self._visit_overloaded_func_def(defn)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 715, in _visit_overloaded_func_def
    found_method_base_classes = self.check_method_override(defn)
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 2050, in check_method_override
    result = self.check_method_or_accessor_override_for_base(
        defn, base, check_override_compatibility
    )
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 2088, in check_method_or_accessor_override_for_base
    if self.check_method_override_for_base_with_name(defn, name, base):
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 2222, in check_method_override_for_base_with_name
    self.check_setter_type_override(defn, base_attr, base)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 2112, in check_setter_type_override
    original_type, is_original_setter = get_raw_setter_type(base_node)
                                        ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
  File "/projects/numtype/.venv/lib/python3.13/site-packages/mypy/checker.py", line 9035, in get_raw_setter_type
    assert var.type is not None
           ^^^^^^^^^^^^^^^^^^^^
AssertionError: 
src/numpy-stubs/ma/core.pyi:308: : note: use --pdb to drop into pdb

Here's the relevant numpy-stubs/ma/core.pyi code: numpy/numtype@3e9fc75/src/numpy-stubs/ma/core.pyi#L304-L311

I removed the .mypy_cache before running it, and installed it by switching "mypy>=1.15.0" to "mypy @ git+https://github.com/python/mypy@new-allow-redefine" in the [dependency-groups] of the pyproject.toml (numpy/numtype@3e9fc75/pyproject.toml#L50) and then running uv sync. Is there something I'm doing wrong?

edit: I just checked again with the --allow-redefinition-new flag, and I'm getting the same traceback.

This crash seems to be unrelated to this PR: #18764

JukkaL added 30 commits February 24, 2025 13:52

WIP some initial prototyping

9735391

WIP add failing test case

946d4d5

WIP minimal support for merging control flow

7f7e25f

Add globals test case

0c9f049

Add class body test case

9935537

Require --local-partial-types

fd12f85

Fix optional types

b489b6a

Add partial type test cases

d2b7558

Pass options consistently

63bf0af

Fix interaction with Final

ec02654

Add annotated variable test case

4290857

Add test

5c8ab17

Add failing test

c116451

Only use type context in assignment if inference fails without type c…

9794308

…ontext

Always use type annotation as context

a355473

Add while loop test case

8162a45

Fix type inference in loops

b1f75a7

Update tests

62dfbb0

Remove underscore special case

bb6a246

Don't perform renaming when using new semantics

51c61c7

Fix for loops

0384795

WIP failing tests

a003c83

Add try/except test case

a35870e

Add match statement test

dea9148

Add simple nested function test case

2b104dc

Update globals tests case

6a05baf

Add assignment expression test case

b58be6a

Add lambda test case

5b31950

Tests for imports

bcaace1

Add operator assignment test case

ad90125

JukkaL added 10 commits February 24, 2025 13:52

Black and ruff

4af080c

More tweaks

c478514

Prevent wideding of variable defined in outer scope

fb9421f

Add comment

a29a3dc

Fix issue

ff7557b

Some polish

10b6082

Don't widen final variables

e8789e0

Fix incremental mode

9494ddc

Simplify

fed6d45

Detect invalid per-module options

aaefd4b

JukkaL requested a review from ilevkivskyi February 24, 2025 14:17

This comment has been minimized.

Sign in to view

Fix typo

d7c35e4

This comment has been minimized.

Sign in to view

Skip failing match statement test on 3.9

5bd6def

This comment has been minimized.

Sign in to view

Don't infer infinitely complex types in loops

3e38e7d

jorenham mentioned this pull request Mar 5, 2025

Issues related to numpy #18343

Open

This comment was marked as off-topic.

Sign in to view

ilevkivskyi reviewed Mar 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add flag to allow more flexible variable redefinition #18727

Add flag to allow more flexible variable redefinition #18727

JukkaL commented Feb 24, 2025 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cdce8p commented Feb 26, 2025

JukkaL commented Feb 26, 2025

github-actions bot commented Feb 27, 2025

cdce8p commented Feb 27, 2025

A5rocks commented Feb 28, 2025 •

edited

Loading

hauntsaninja commented Feb 28, 2025

ilevkivskyi commented Feb 28, 2025

This comment was marked as off-topic.

ilevkivskyi commented Mar 5, 2025

jorenham commented Mar 5, 2025

ilevkivskyi left a comment

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

ilevkivskyi Mar 6, 2025

jorenham commented Mar 7, 2025

		@@ -3286,7 +3317,10 @@ def check_assignment(
		lvalue_type = make_optional_type(lvalue_type)
		self.set_inferred_type(lvalue.node, lvalue, lvalue_type)

Add flag to allow more flexible variable redefinition #18727

Are you sure you want to change the base?

Add flag to allow more flexible variable redefinition #18727

Conversation

JukkaL commented Feb 24, 2025 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cdce8p commented Feb 26, 2025

JukkaL commented Feb 26, 2025

github-actions bot commented Feb 27, 2025

cdce8p commented Feb 27, 2025

A5rocks commented Feb 28, 2025 • edited Loading

hauntsaninja commented Feb 28, 2025

ilevkivskyi commented Feb 28, 2025

This comment was marked as off-topic.

ilevkivskyi commented Mar 5, 2025

jorenham commented Mar 5, 2025

ilevkivskyi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorenham commented Mar 7, 2025

JukkaL commented Feb 24, 2025 •

edited

Loading

A5rocks commented Feb 28, 2025 •

edited

Loading