Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update croniter to 6.0.0 #13548

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update croniter to 6.0.0 #13548

wants to merge 3 commits into from

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Feb 26, 2025

Make class croniter generic over ret_type and tighten return types for some methods.

Closes: #13260

srittau and others added 3 commits February 26, 2025 18:43
Make class `croniter` generic over `ret_type` and tighten
return types for some methods.
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

paasta (https://github.com/yelp/paasta)
+ paasta_tools/cli/cmds/validate.py:874: error: List comprehension has incompatible type List[float]; expected List[str]  [misc]

@srittau
Copy link
Collaborator Author

srittau commented Feb 26, 2025

Primer hit is a true positive. The error had been hidden before, since get_next() yielded Any. (But that's only a problem in the annotations. The code only uses the return value for printing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant