Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyInstaller: Complete types in splash.pyi #13568

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

Sabfo
Copy link
Contributor

@Sabfo Sabfo commented Mar 1, 2025

No description provided.

This comment has been minimized.

@Avasam Avasam self-requested a review March 1, 2025 23:05

This comment has been minimized.

@Sabfo
Copy link
Contributor Author

Sabfo commented Mar 2, 2025

Thanks for your review. I've updated the types for the requested attributes.
I think we can or even should simplify the type for script_name to str if you think that will be better for consistency and actually anyway Splash doesn't use and import into a user code.

@Sabfo Sabfo requested a review from Avasam March 2, 2025 13:00
Co-authored-by: Avasam <samuel.06@hotmail.com>
Copy link
Contributor

github-actions bot commented Mar 7, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Avasam Avasam merged commit a91c147 into python:main Mar 7, 2025
43 checks passed
@Sabfo Sabfo deleted the pyinstaller-improve-splash branch March 8, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants