Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: OAuth1 type hints to include realm parameter #13579

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Fix: OAuth1 type hints to include realm parameter #13579

merged 4 commits into from
Mar 5, 2025

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #13463

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nit below.

Mr-Sunglasses
Mr-Sunglasses commented Mar 5, 2025
View reviewed changes
Copy link
Contributor Author

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srittau , I've made the changes.

@Mr-Sunglasses Mr-Sunglasses requested a review from srittau March 5, 2025 17:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 91a90ed into python:main Mar 5, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requests_oauthlib OAuth1 is incorrectly typed
2 participants
@Mr-Sunglasses @srittau