Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: julienXX/terminal-notifier
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: radiant-player/terminal-notifier
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: radiant-logo
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 6 commits
  • 5 files changed
  • 4 contributors

Commits on Aug 16, 2015

  1. Correct flag conflict when using -sender

    djui authored and julienXX committed Aug 16, 2015
    Copy the full SHA
    66fd101 View commit details
  2. Merge branch 'djui-patch-1'

    julienXX committed Aug 16, 2015
    Copy the full SHA
    f727ffd View commit details

Commits on Nov 25, 2015

  1. Copy the full SHA
    5093496 View commit details
  2. Merge pull request #152 from ReadmeCritic/master

    Update README URLs based on HTTP redirects
    julienXX committed Nov 25, 2015
    Copy the full SHA
    2d88d61 View commit details

Commits on May 26, 2016

  1. Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    8a302d9 View commit details
  2. Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    81714f6 View commit details
Showing with 13 additions and 7 deletions.
  1. +8 −4 README.markdown
  2. +2 −0 Terminal Notifier.xcodeproj/project.pbxproj
  3. +2 −2 Terminal Notifier/AppDelegate.m
  4. +1 −1 Terminal Notifier/Terminal Notifier-Info.plist
  5. BIN Terminal.icns
12 changes: 8 additions & 4 deletions README.markdown
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# NOTE

**You likely want to use the upstream project, [julienXX/terminal-notifier](https://github.com/julienXX/terminal-notifier). This fork tracks master there, with the icon changed for Radiant Player.**

# terminal-notifier

terminal-notifier is a command-line tool to send Mac OS X User Notifications,
@@ -27,7 +31,7 @@ which are available in Mac OS X 10.8 and higher.
## Download

Prebuilt binaries are available from the
[releases section](https://github.com/alloy/terminal-notifier/releases).
[releases section](https://github.com/julienXX/terminal-notifier/releases).

Or if you want to use this from
[Ruby](https://github.com/alloy/terminal-notifier/tree/master/Ruby), you can
@@ -37,7 +41,7 @@ install it through RubyGems:
$ [sudo] gem install terminal-notifier
```

You can also install it via [Homebrew](https://github.com/mxcl/homebrew):
You can also install it via [Homebrew](https://github.com/Homebrew/homebrew):
```
$ brew install terminal-notifier
```
@@ -159,8 +163,8 @@ application instead, including using its icon.
Using this option fakes the sender application, so that the notification system
will launch that application when the notification is clicked. Because of this
it is important to note that you cannot combine this with options like
`-execute` and `-activate` which depend on the sender of the notification to be
‘terminal-notifier’ to perform its work.
`-execute`, `-open`, and `-activate` which depend on the sender of the
notification to be ‘terminal-notifier’ to perform its work.

For information on the `ID` see the `-activate` option.

2 changes: 2 additions & 0 deletions Terminal Notifier.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
@@ -266,6 +266,7 @@
GCC_PREFIX_HEADER = "Terminal Notifier/Terminal Notifier-Prefix.pch";
INFOPLIST_FILE = "Terminal Notifier/Terminal Notifier-Info.plist";
MACOSX_DEPLOYMENT_TARGET = 10.8;
PRODUCT_BUNDLE_IDENTIFIER = "nl.superalloy.oss.terminal-notifier.radiant";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE = "";
SDKROOT = macosx;
@@ -281,6 +282,7 @@
GCC_PREFIX_HEADER = "Terminal Notifier/Terminal Notifier-Prefix.pch";
INFOPLIST_FILE = "Terminal Notifier/Terminal Notifier-Info.plist";
MACOSX_DEPLOYMENT_TARGET = 10.8;
PRODUCT_BUNDLE_IDENTIFIER = "nl.superalloy.oss.terminal-notifier.radiant";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE = "";
SDKROOT = macosx;
4 changes: 2 additions & 2 deletions Terminal Notifier/AppDelegate.m
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
#import <ScriptingBridge/ScriptingBridge.h>
#import <objc/runtime.h>

NSString * const TerminalNotifierBundleID = @"nl.superalloy.oss.terminal-notifier";
NSString * const TerminalNotifierBundleID = @"nl.superalloy.oss.terminal-notifier.radiant";
NSString * const NotificationCenterUIBundleID = @"com.apple.notificationcenterui";

// Set OS Params
@@ -75,7 +75,7 @@ +(void)initializeUserDefaults

if (isMavericks()) {
//10.9
appDefaults = @{@"sender": @"com.apple.Terminal"};
appDefaults = @{@"sender": TerminalNotifierBundleID};
} else {
//10.8
appDefaults = @{@"": @"message"};
2 changes: 1 addition & 1 deletion Terminal Notifier/Terminal Notifier-Info.plist
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
<key>CFBundleIconFile</key>
<string>Terminal</string>
<key>CFBundleIdentifier</key>
<string>nl.superalloy.oss.${PRODUCT_NAME:rfc1034identifier}</string>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
Binary file modified Terminal.icns
Binary file not shown.