Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: novnc/noVNC
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: realityengines/noVNC
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Dec 13, 2024

  1. remove sound play

    @sravan-abacus
    sravan-abacus committed Dec 13, 2024
    Copy the full SHA
    90a1713 View commit details

Commits on Feb 19, 2025

  1. remove control bar anchor

    @junchen6072
    junchen6072 committed Feb 19, 2025
    Copy the full SHA
    8a017c3 View commit details

  2. Merge pull request #1 from realityengines/users/jun/remove_control_ba… 

    …r_anchor

remove control bar anchor
    @junchen6072
    junchen6072 authored Feb 19, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    57c8662 View commit details
Showing with 19 additions and 27 deletions.
  1. +16 −15 app/ui.js
  2. +3 −12 vnc.html
31 changes: 16 additions & 15 deletions app/ui.js
View file
Original file line number Diff line number Diff line change
@@ -1765,21 +1765,22 @@ const UI = {
},

bell(e) {
if (UI.getSetting('bell') === 'on') {
const promise = document.getElementById('noVNC_bell').play();
// The standards disagree on the return value here
if (promise) {
promise.catch((e) => {
if (e.name === "NotAllowedError") {
// Ignore when the browser doesn't let us play audio.
// It is common that the browsers require audio to be
// initiated from a user action.
} else {
Log.Error("Unable to play bell: " + e);
}
});
}
}
return;
// if (UI.getSetting('bell') === 'on') {
// const promise = document.getElementById('noVNC_bell').play();
// // The standards disagree on the return value here
// if (promise) {
// promise.catch((e) => {
// if (e.name === "NotAllowedError") {
// // Ignore when the browser doesn't let us play audio.
// // It is common that the browsers require audio to be
// // initiated from a user action.
// } else {
// Log.Error("Unable to play bell: " + e);
// }
// });
// }
// }
},

//Helper to add options to dropdown.
15 changes: 3 additions & 12 deletions vnc.html
View file
Original file line number Diff line number Diff line change
@@ -108,7 +108,7 @@
</div>
</div>

<!-- noVNC control bar -->
<!--
<div id="noVNC_control_bar_anchor" class="noVNC_vcenter">
<div id="noVNC_control_bar">
@@ -120,18 +120,15 @@ <h1 class="noVNC_logo" translate="no"><span>no</span><br>VNC</h1>
<hr>
<!-- Drag/Pan the viewport -->
<input type="image" alt="Drag" src="app/images/drag.svg"
id="noVNC_view_drag_button" class="noVNC_button noVNC_hidden"
title="Move/Drag viewport">
<!--noVNC touch device only buttons-->
<div id="noVNC_mobile_buttons">
<input type="image" alt="Keyboard" src="app/images/keyboard.svg"
id="noVNC_keyboard_button" class="noVNC_button" title="Show keyboard">
</div>
<!-- Extra manual keys -->
<input type="image" alt="Extra keys" src="app/images/toggleextrakeys.svg"
id="noVNC_toggle_extra_keys_button" class="noVNC_button"
title="Show extra keys">
@@ -158,7 +155,6 @@ <h1 class="noVNC_logo" translate="no"><span>no</span><br>VNC</h1>
</div>
</div>
<!-- Shutdown/Reboot -->
<input type="image" alt="Shutdown/Reboot" src="app/images/power.svg"
id="noVNC_power_button" class="noVNC_button"
title="Shutdown/Reboot...">
@@ -173,7 +169,6 @@ <h1 class="noVNC_logo" translate="no"><span>no</span><br>VNC</h1>
</div>
</div>
<!-- Clipboard -->
<input type="image" alt="Clipboard" src="app/images/clipboard.svg"
id="noVNC_clipboard_button" class="noVNC_button"
title="Clipboard">
@@ -189,12 +184,10 @@ <h1 class="noVNC_logo" translate="no"><span>no</span><br>VNC</h1>
</div>
</div>
<!-- Toggle fullscreen -->
<input type="image" alt="Full screen" src="app/images/fullscreen.svg"
id="noVNC_fullscreen_button" class="noVNC_button noVNC_hidden"
title="Full screen">
<!-- Settings -->
<input type="image" alt="Settings" src="app/images/settings.svg"
id="noVNC_settings_button" class="noVNC_button"
title="Settings">
@@ -272,7 +265,6 @@ <h1 class="noVNC_logo" translate="no"><span>no</span><br>VNC</h1>
<label><input id="noVNC_setting_show_dot" type="checkbox"> Show dot when no cursor</label>
</li>
<li><hr></li>
<!-- Logging selection dropdown -->
<li>
<label>Logging:
<select id="noVNC_setting_logging" name="vncLogging">
@@ -290,16 +282,15 @@ <h1 class="noVNC_logo" translate="no"><span>no</span><br>VNC</h1>
</div>
</div>
<!-- Connection controls -->
<input type="image" alt="Disconnect" src="app/images/disconnect.svg"
id="noVNC_disconnect_button" class="noVNC_button"
title="Disconnect">
</div>
</div>
</div> <!-- End of noVNC_control_bar -->

</div>
-->
<div id="noVNC_hint_anchor" class="noVNC_vcenter">
<div id="noVNC_control_bar_hint">
</div>