-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(config): managerFilePatterns #34615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some more samples, which can be simplified by using glob, otherwise LGTM
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can do the regex to glob changes in a followup pr of cause
needs update because of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review done. Please note each of the suggested changes and apply them widely to the whole PR. e.g. ^foo$
patterns should always just be foo
.
docs/usage/user-stories/maintaining-aur-packages-with-renovate.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until second week of April
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume we agreed to simplify regex patterns in a follow up pr 🙃
Merge after v40 or before? I worry about backporting fixes into v39 if we do it before |
Do we plan to release v40 shortly? Else a lot of conflicts will creep in. |
I think by end of next week |
In that case I'm for releasing it with v40 |
🎉 This PR is included in version 40.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com> Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Co-authored-by: Michael Kriese <michael.kriese@visualon.de> Co-authored-by: Rhys Arkins <rhys@arkins.net>
Changes
fileMatch
tofilePatterns
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
managerFilePatterns
)