feat(config): filePatterns #34615
Open
feat(config): filePatterns #34615
+538
−445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulGautamSingh
requested review from
rarkins,
HonkingGoose,
viceice and
secustor
secustor
reviewed
Mar 4, 2025
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
HonkingGoose
suggested changes
Mar 5, 2025
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
6 tasks
viceice
reviewed
Mar 5, 2025
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
secustor
previously approved these changes
Mar 5, 2025
viceice
reviewed
Mar 6, 2025
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
reviewed
Mar 6, 2025
|
needs update because of: |
trim21
reviewed
Mar 7, 2025
rarkins
requested changes
Mar 7, 2025
docs/usage/user-stories/maintaining-aur-packages-with-renovate.md
Outdated
Show resolved
Hide resolved
| @@ -78,7 +78,7 @@ export const presets: Record<string, Preset> = { | |||
| { | |||
| customType: 'regex', | |||
| datasourceTemplate: 'docker', | |||
| fileMatch: ['(^|/)Chart\\.yaml$'], | |||
| filePatterns: ['/(^|/)Chart\\.yaml$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)Chart\\.yaml$/'], | |
| filePatterns: ['**/Chart.yaml'], |
viceice
reviewed
Mar 9, 2025
| @@ -792,7 +792,7 @@ Example: | |||
| "customManagers": [ | |||
| { | |||
| "customType": "regex", | |||
| "fileMatch": ["values.yaml$"], | |||
| "filePatterns": ["**values.yaml"], | |||
There was a problem hiding this comment.
Suggested change
| "filePatterns": ["**values.yaml"], | |
| "filePatterns": ["**/values.yaml"], |
| @@ -884,7 +884,7 @@ Only the `json`, `toml` and `yaml` formats are supported. | |||
| { | |||
| "customType": "jsonata", | |||
| "fileFormat": "toml", | |||
| "fileMatch": ["file.toml"], | |||
| "filePatterns": ["some/file.toml"], | |||
There was a problem hiding this comment.
is this path change intentional?
|
|
||
| ```json | ||
| { | ||
| "kubernetes": { | ||
| "fileMatch": ["^config/.*\\.yaml$"] | ||
| "filePatterns": ["/^config/.*\\.yaml$/"] |
There was a problem hiding this comment.
Suggested change
| "filePatterns": ["/^config/.*\\.yaml$/"] | |
| "filePatterns": ["config/**/*.yaml"] |
looks simpler
| @@ -78,7 +78,7 @@ export const presets: Record<string, Preset> = { | |||
| { | |||
| customType: 'regex', | |||
| datasourceTemplate: 'docker', | |||
| fileMatch: ['(^|/)Chart\\.yaml$'], | |||
| filePatterns: ['/(^|/)Chart\\.yaml$/'], | |||
| '(^|/)GNUMakefile$', | ||
| '\\.mk$', | ||
| ], | ||
| filePatterns: ['**/Makefile', '**/GNUMakefile', '**/*.mk'], |
There was a problem hiding this comment.
are you sure glob is case insensitive?
Suggested change
| filePatterns: ['**/Makefile', '**/GNUMakefile', '**/*.mk'], | |
| filePatterns: ['**/{M,m}akefile', '**/GNUMakefile', '**/*.mk'], |
There was a problem hiding this comment.
Rhys, suggested that it is case insensitive. I didn't double check and went with the suggestion.
I looked it up and there seems to be mixed answers. I will apply your suggestion to be 100% safe.
| @@ -109,7 +104,7 @@ export const presets: Record<string, Preset> = { | |||
| customType: 'regex', | |||
| datasourceTemplate: | |||
| '{{#if datasource}}{{{datasource}}}{{else}}maven{{/if}}', | |||
| fileMatch: ['(^|/)pom\\.xml$'], | |||
| filePatterns: ['/(^|/)pom\\.xml$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)pom\\.xml$/'], | |
| filePatterns: ['**/pom.xml'], |
| @@ -122,7 +117,7 @@ export const presets: Record<string, Preset> = { | |||
| customManagers: [ | |||
| { | |||
| customType: 'regex', | |||
| fileMatch: ['.+\\.tfvars$'], | |||
| filePatterns: ['/.+\\.tfvars$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/.+\\.tfvars$/'], | |
| filePatterns: ['**/*.tfvars'], |
simplify others too where possible
| @@ -91,7 +91,7 @@ Here is the Renovate configuration to use Terraform, `aws-rds` and Aurora MySQL: | |||
| { | |||
| "description": "Update RDS", | |||
| "customType": "regex", | |||
| "fileMatch": [".+\\.tf$"], | |||
| "filePatterns": ["/.+\\.tf$/"], | |||
There was a problem hiding this comment.
Suggested change
| "filePatterns": ["/.+\\.tf$/"], | |
| "filePatterns": ["**/*.tf"], |
prefer glob in samples where possible
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
secustor
reviewed
Mar 9, 2025
|
|
||
| ```json | ||
| { | ||
| "fileMatch": ["'(^|/)fleet.ya?ml", "myGitRepoManifests\\.yaml"] | ||
| "filePatterns": ["**/fleet.{yaml,yml}", "**myGitRepoManifests.yaml"] |
There was a problem hiding this comment.
Suggested change
| "filePatterns": ["**/fleet.{yaml,yml}", "**myGitRepoManifests.yaml"] | |
| "filePatterns": ["**/fleet.{yaml,yml}", "**/myGitRepoManifests.yaml"] |
|
|
||
| ```json | ||
| { | ||
| "pip-compile": { | ||
| "fileMatch": ["(^|/)requirements\\.txt$"] | ||
| "filePatterns": ["**/requirements\\.txt"] |
There was a problem hiding this comment.
Suggested change
| "filePatterns": ["**/requirements\\.txt"] | |
| "filePatterns": ["**/requirements.txt"] |
Comment on lines
+16
to
+17
| '/(^|/)pyproject\\.toml$/', // `tool.pixi` section | ||
| '/(^|/)pixi\\.toml$/', // root object |
There was a problem hiding this comment.
Suggested change
| '/(^|/)pyproject\\.toml$/', // `tool.pixi` section | |
| '/(^|/)pixi\\.toml$/', // root object | |
| '**/pyproject.toml', // `tool.pixi` section | |
| '**/pixi.toml', // root object |
| @@ -9,7 +9,7 @@ export const url = 'https://www.puppet.com/docs/index.html'; | |||
| export const categories: Category[] = ['iac', 'ruby']; | |||
|
|
|||
| export const defaultConfig = { | |||
| fileMatch: ['(^|/)Puppetfile$'], | |||
| filePatterns: ['/(^|/)Puppetfile$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)Puppetfile$/'], | |
| filePatterns: ['**/Puppetfile'], |
| @@ -9,7 +9,7 @@ export const url = 'https://github.com/pyenv/pyenv#readme'; | |||
| export const categories: Category[] = ['python']; | |||
|
|
|||
| export const defaultConfig = { | |||
| fileMatch: ['(^|/)\\.python-version$'], | |||
| filePatterns: ['/(^|/)\\.python-version$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)\\.python-version$/'], | |
| filePatterns: ['**/.python-version'], |
| @@ -8,7 +8,7 @@ export const url = 'https://cakebuild.net/docs'; | |||
| export const categories: Category[] = ['dotnet']; | |||
|
|
|||
| export const defaultConfig = { | |||
| fileMatch: ['\\.cake$'], | |||
| filePatterns: ['/\\.cake$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/\\.cake$/'], | |
| filePatterns: ['**/*.cake'], |
| @@ -16,7 +16,7 @@ export const categories: Category[] = ['rust']; | |||
|
|
|||
| export const defaultConfig = { | |||
| commitMessageTopic: 'Rust crate {{depName}}', | |||
| fileMatch: ['(^|/)Cargo\\.toml$'], | |||
| filePatterns: ['/(^|/)Cargo\\.toml$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)Cargo\\.toml$/'], | |
| filePatterns: ['**/Cargo.toml'], |
| @@ -13,7 +13,7 @@ export const url = 'https://cocoapods.org'; | |||
| export const categories: Category[] = ['swift']; | |||
|
|
|||
| export const defaultConfig = { | |||
| fileMatch: ['(^|/)Podfile$'], | |||
| filePatterns: ['/(^|/)Podfile$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)Podfile$/'], | |
| filePatterns: ['**/Podfile'], |
| @@ -10,7 +10,7 @@ export const url = | |||
| export const categories: Category[] = ['perl']; | |||
|
|
|||
| export const defaultConfig = { | |||
| fileMatch: ['(^|/)cpanfile$'], | |||
| filePatterns: ['/(^|/)cpanfile$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)cpanfile$/'], | |
| filePatterns: ['**/cpanfile'], |
| @@ -6,7 +6,7 @@ export { updateArtifacts } from './artifacts'; | |||
| export const supportsLockFileMaintenance = true; | |||
|
|
|||
| export const defaultConfig = { | |||
| fileMatch: ['(^|/)devbox\\.json$'], | |||
| filePatterns: ['/(^|/)devbox\\.json$/'], | |||
There was a problem hiding this comment.
Suggested change
| filePatterns: ['/(^|/)devbox\\.json$/'], | |
| filePatterns: ['**/devbox.json'], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fileMatchtofilePatternsContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: