Skip to content

feat(config): managerFilePatterns #34615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 4, 2025
Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Mar 4, 2025

Changes

  • Migrate fileMatch to filePatterns
  • Add glob pattern support

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
  1. https://github.com/Rahul-renovate-testing/renovate/pulls (test run on renovate repo)
  2. https://github.com/Rahul-renovate-testing/managerFilePatterns (migration testing & tested working of managerFilePatterns)

Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
secustor
secustor previously approved these changes Mar 5, 2025
@RahulGautamSingh RahulGautamSingh requested a review from viceice March 5, 2025 20:54
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some more samples, which can be simplified by using glob, otherwise LGTM

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do the regex to glob changes in a followup pr of cause

@viceice
Copy link
Member

viceice commented Mar 6, 2025

needs update because of:

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review done. Please note each of the suggested changes and apply them widely to the whole PR. e.g. ^foo$ patterns should always just be foo.

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until second week of April

viceice
viceice previously approved these changes Apr 1, 2025
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume we agreed to simplify regex patterns in a follow up pr 🙃

@rarkins rarkins dismissed stale reviews from viceice and secustor via f97c89d April 8, 2025 18:47
rarkins
rarkins previously approved these changes Apr 8, 2025
@rarkins
Copy link
Collaborator

rarkins commented Apr 24, 2025

Merge after v40 or before? I worry about backporting fixes into v39 if we do it before

@secustor
Copy link
Collaborator

Do we plan to release v40 shortly? Else a lot of conflicts will creep in.

@rarkins
Copy link
Collaborator

rarkins commented Apr 24, 2025

I think by end of next week

@secustor
Copy link
Collaborator

I think by end of next week

In that case I'm for releasing it with v40

@rarkins rarkins added this pull request to the merge queue May 4, 2025
Merged via the queue into renovatebot:main with commit bc7d059 May 4, 2025
40 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 40.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mikutas added a commit to mikutas/dotfiles that referenced this pull request May 9, 2025
RGunning pushed a commit to RGunning/renovate that referenced this pull request May 25, 2025
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate fileMatch to filePatterns and support matchRegexOrGlobList
7 participants