feat: support .npmrc for custom repo detection in bun projects #34322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-dahl
changed the title
rarkins
reviewed
Feb 21, 2025
| @@ -4,7 +4,7 @@ import { NpmDatasource } from '../../datasource/npm'; | |||
|
|
|||
| export { updateArtifacts } from './artifacts'; | |||
| export { extractAllPackageFiles } from './extract'; | |||
| export { getRangeStrategy, updateDependency } from '../npm'; | |||
| export { getRangeStrategy, updateDependency, detectGlobalConfig } from '../npm'; | |||
There was a problem hiding this comment.
If this isn't essential for this PR, please move it to a separate discussion. I'm not sure this export even achieves anything
rarkins
reviewed
Feb 21, 2025
Comment on lines
+18
to
+20
| const formatNpmrc = ( | ||
| ...npmrcs: (string | undefined | null)[] | ||
| ): string | undefined => { |
There was a problem hiding this comment.
Please avoid nesting of functions
viceice
reviewed
Feb 21, 2025
| import { newlineRegex } from '../../../../../util/regex'; | ||
| import type { ExtractConfig } from '../../../types'; | ||
|
|
||
| export async function readNpmrc( |
There was a problem hiding this comment.
please do this refactor in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
this moves the npm logic to read .npmrc into a helper function then calls that helper function in both npm and bun managers. it also exports npm's detectGlobalConfig function from bun.
Context
there is no issue for this PR
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: