Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: require node v22.13 #34524

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!: require node v22.13 #34524

wants to merge 1 commit into from

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 27, 2025

Changes

  • Require Node v22.13 for cjs-esm compabillity

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the breaking Breaking change, requires major version bump label Feb 27, 2025
@viceice viceice added this to the v40 milestone Feb 27, 2025
@trim21
Copy link
Contributor

trim21 commented Mar 1, 2025

I think we do not actually this in production? This only affect development env for running tests and can be fixed by rename one ts file to mts file?

@viceice
Copy link
Member Author

viceice commented Mar 1, 2025

no, we need it to allow require esm only dependencies. see next branch for samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants