Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelogs): Pass depName to addReleaseNotes #34617

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

bjw-s
Copy link
Contributor

@bjw-s bjw-s commented Mar 4, 2025

Changes

This PR sets the depName on the ChangeLogProject that gets passed to the addReleaseNotes function.

Context

When debugging why the changelog was not being added for one of my projects I noticed the following in my Renovate log lines:

DEBUG: getReleaseNotes(bjw-s/helm-charts, 3.7.2, ghcr.io/bjw-s/helm/app-template, undefined) (repository=bjw-s-labs/home-ops, branch=renovate/app-template-3.x)

In #30395 functionality was added to include depName in the release selection for changelogs, but it looks like the depName is not being forwarded to the functions that handle fetching the changelog, causing the undefined in the downstream getReleaseNotes function.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Signed-off-by: Bernd Schorgers <me@bjw-s.dev>
@bjw-s bjw-s changed the title fix(changelogs): Pass depName to getChangeLogJSON fix(changelogs): Pass depName to addReleaseNotes Mar 4, 2025
Signed-off-by: Bernd Schorgers <me@bjw-s.dev>
@rarkins rarkins requested review from viceice and secustor March 9, 2025 09:32
@rarkins rarkins added this pull request to the merge queue Mar 9, 2025
Merged via the queue into renovatebot:main with commit 9f3f85c Mar 9, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.191.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants