add env for roboflow serverless service #1059
Merged
+28
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacificDou
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux,
hansent and
EmilyGavrilenko
as code owners
inference/core/env.py
Outdated
| @@ -515,3 +515,5 @@ | |||
| ) | |||
| if IGNORE_MODEL_DEPENDENCIES_WARNINGS: | |||
| warnings.simplefilter("ignore", ModelDependencyMissing) | |||
|
|
|||
| IS_ROBOFLOW_SERVERLESS = str2bool(os.getenv("IS_ROBOFLOW_SERVERLESS", "False")) | |||
There was a problem hiding this comment.
I'd vote for changing this variable name to something more specific, i.e. GCP_SERVERLESS.
Or we could reuse LAMBDA instead of introducing new env variable - it would make sense to reuse LAMBDA since we are going to replicate AWS (with Redis and offloader)
There was a problem hiding this comment.
let's go GCP_SERVERLESS
PawelPeczek-Roboflow
approved these changes
Mar 7, 2025
grzegorz-roboflow
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/model/*which are required by mode v1/infer/*because our authoriser does not support api_key in json body, will enable these endpoints later when we updated the authorizerList any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested in staging
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs