fix: support plugin-legacy #80
Draft
+4,568
−2,702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: underfin <likui.underfin@gmail.com>
Co-authored-by: underfin <likui.underfin@gmail.com>
Co-authored-by: underfin <likui.underfin@gmail.com>
Co-authored-by: underfin <likui.underfin@gmail.com>
Co-authored-by: IWANABETHATGUY <iwanabethatguy@qq.com>
Co-authored-by: IWANABETHATGUY <iwanabethatguy@qq.com>
chore: revert package name change + use non-compact continuous release URLs chore: update lockfile
* feat: use oxc for lowering * chore: skip modulepreload polyfill test for now
* feat: use transformWithOxc for extractExportsData * feat: make esbuild optional peer dep * chore: fix types
it's now a dep
hi-ogawa
force-pushed
the
fix-legacy-systemjs
branch
from
bd2f275 to
e67953d
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
from
5a3ed8b to
9219b3a
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
2 times, most recently
from
3b78414 to
794aea0
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
from
eed741a to
c0a08a6
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
2 times, most recently
from
45eceea to
82737df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rolldown/rolldown#2387, I'm experimenting with running systemjs transform inside legacy plugin as it already has babel plugin transform.
I found a few things rolldown is missing as rollup compat. Not working yet, but it looks doable by working around on plugin side.
rollup compat issues
"system"formatbundle[filename] = legacyPolyfillChunkto add an entire chunk is not supportedemitFile({ type: "asset" })is enough?outputToChunkFileNameToPolyfills, which relies on object identity and mutation of js plugin arguments?opts.__vite_skip_esbuild__, __vite_force_terser__, etc...meta.chunksinrenderChunk(..., meta)[Tracking] Rollup Plugin Compat Status rolldown/rolldown#819