added fips flag #290
Open
added fips flag #290
+34
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for the interest in Gemstash. There are tests covering the returned configuration, and they now fail. |
looks like there were some additional differences in that config too. i've addressed those so that spec passes now. |
benklop
commented
Mar 22, 2021
| @@ -35,6 +39,8 @@ | |||
| puma_workers: 1 | |||
| cache_expiration: 1800 | |||
| cache_max_size: 500 | |||
| storage_adapter: local | |||
| s3_path: gemstash/s3_storage | |||
There was a problem hiding this comment.
These were not due to changes I made, but were needed to get the spec to pass
|
@benklop could you rebase this PR with master please, thank you! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently gemstash is not usable in environments with fips enforcement. #195 Tried to resolve this but has stalled for 3 years since it seems this needs to be enabled with a flag. @olleolleolle updated the changeset to add such a flag, but the changes never made it back here. In the meantime the diff stopped applying cleanly, I have fixed that and opened this PR.
I have made this use the config file option
fipsinstead of a flag.I will abide by the code of conduct.