Flatten oneOf/allOf property schemas #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrii-balitskyi
commented
Mar 4, 2025
•
andrii-balitskyi
commented
- flattenAllOfSchema and flattenOneOfSchema should gather property enum values from all subschemas
- Test flattening functions update
- Flatten oneOf/allOf property schemas
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
razor-x
approved these changes
Mar 4, 2025
| } else { | ||
| t.fail('Expected "type" property to exist') | ||
| } | ||
| } else { |
There was a problem hiding this comment.
This was a bit hard for me to follow. Should be simpler if you do all the nil checks up front.
if (foo == null) {
t.fail('foo was null')
return
}
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.