Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Unable to upload "gosec-results.sarif" as it is not valid SARIF #1234

Closed
maryamtahhan opened this issue Sep 24, 2024 · 5 comments
Closed

Comments

@maryamtahhan
Copy link

We've been having consistent failures with our gosec github workflow since updating from 2.20.0 to any newer versions:

https://github.com/sustainable-computing-io/kepler/actions/runs/11015749623/job/30589569438#step:5:5058

Going to revery back to 2.20.0 but not sure why this is still failing...

@ccojocar
Copy link
Member

I see that your workflow used the v2.21.2 version of the gosec action. You need to use the @master version of the action which uses the gosec v2.21.3 underneath. This was fixed and this is a test pull request which updates successfully the SARIF file #1228.

@maryamtahhan
Copy link
Author

maryamtahhan commented Sep 24, 2024

We were tracking master: https://github.com/sustainable-computing-io/kepler/actions/runs/10783384527/job/29905195797

That's when the failures started. I reverted to 2.20.0 as this was the last stable release we had https://github.com/sustainable-computing-io/kepler/pull/1778/files

@ccojocar
Copy link
Member

@maryamtahhan This is not master:
image

You use the 2.21.2 version of the action which underneath uses 2.21.1 version of gosec. You need to use the @master version of the GitHub action if you want to have it working.

@maryamtahhan
Copy link
Author

thanks @ccojocar for getting back to me. If you expand Run Gosec Security Scanner in that same job, you should see Run securego/gosec@master

Screenshot 2024-09-25 at 12 59 09

I will try the latest master again, hopefully it will work

@maryamtahhan
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants