Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't assign bookmarks when using a CMake project #38

Open
TheNicker opened this issue Apr 8, 2022 · 6 comments
Open

Can't assign bookmarks when using a CMake project #38

TheNicker opened this issue Apr 8, 2022 · 6 comments
Assignees

Comments

@TheNicker
Copy link

TheNicker commented Apr 8, 2022

image

Windows 10 21H2m
Visual studio 17.1.3

Test project: Test.zip

  1. Open the test project as CMake project,
  2. Navigate to Test.cpp and try to toggle a bookmark by pressing Ctrl+Shift+[Number]
  3. BUG: a bookmark isn't being assigned
@sergey-visual-studio
Copy link
Owner

Will investigate, thanks. Sorry about the delay in response. Somehow I stopped getting Github notifications.

@sergey-visual-studio
Copy link
Owner

I'll need help figuring out what makes CMake menu item appear there. It's missing in my environment unfortunately.

You also say "open test project". I don't see any project or solution file in .zip attached. Please clarify. Thanks.

@TheNicker
Copy link
Author

Add CMake tools for windows as depicted below:

  1. Open tools and features
    image

  2. Add C++ CMake tools
    image

The issue happens when using a CMake project file
In the root folder inside the zip there's a file called CMakeLists.txt. That's the project/solution file.

File->Open->Cmake-> Then choose the file CMakeLists.txt and the project will open.

In Visual studio 2019 with DPack there's no issue, Though DPackRX with VS2022 has this issue, just checked with the current latest version VS2022 17.4.0

@sergey-visual-studio
Copy link
Owner

Take a look at issue #43 where I posted a beta version. Give it a try to see if that helps before I start getting into this issue.

@TheNicker
Copy link
Author

@sergey-visual-studio , thanks for your reply.
Tried with DPackRx-4.5.2.1.vsix.zip
Unfortunately it didn't solve the issue.

@sergey-visual-studio
Copy link
Owner

Reproduced it here.

In Visual studio 2019 with DPack there's no issue,

I don't see how that'd be the case tbhwy. For a few reasons: 1 - it doesn't work the same exact way for me on VS 2019, 2 - both versions of DPack bookmarks feature have identical command availability logic, and 3 - both versions require solution to be opened for bookmark commands to be available. That last point is what prevents it from enabling the bookmarks cause as far as VS goes, it reports no open solution. There is quite a bit of DPack logic that relies on open solution. I'll check if relaxing that requirement is feasible or not. I suspect not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants