Inline servo demos into the website #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico Burns <nico@nicoburns.com>
|
Preview link: https://servo.org/inline-servo-demos/ |
|
It looks like a good idea to add the contents of demo.servo.org on the main website. Though most of those demos are pretty old and we should look into creating some new ones (but that's a different topic). Regarding the styles... could we somehow reuse the styles for #220 so both look similar? Maybe moving the styles on #220 to the CSS file and then reuse them here or something. What do you think? |
|
Yeah, matching the styles with #220 seems like a good idea. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inlines the website from https://demo.servo.org directly into https://servo.org such that the navigation and overall page style is retained on the demos listing page. The demos themselves still link out to https://demo.servo.org, but these open in a new tab so it doesn't cause the same "loss of context".