-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backdrop-filter: should create stacking context in servo. #121
Open
JoshuaBrest
wants to merge
7
commits into
servo:main
Choose a base branch
from
JoshuaBrest:stacking-context-backdrop-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
backdrop-filter: should create stacking context in servo. #121
JoshuaBrest
wants to merge
7
commits into
servo:main
from
JoshuaBrest:stacking-context-backdrop-filter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 816c355 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Servo already supports this selector, it just needs to be turned on. Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Xiaocheng Hu <xiaochengh.work@gmail.com>
616b5d3
to
d37f4c7
Compare
nicoburns
requested changes
Feb 7, 2025
d37f4c7
to
f30d582
Compare
Loirooriol
requested changes
Feb 8, 2025
f30d582
to
e9ccd31
Compare
3 tasks
Signed-off-by: Josh <36625023+JoshuaBrest@users.noreply.github.com>
38716d4
to
ab373c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to create a stacking context to fix some websites that don't specify
isolation
in addition tobackdrop-filter
.