Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Prevent opening .so library file #2415

Open
1 of 3 tasks
ilyasa1211 opened this issue Feb 19, 2025 · 3 comments
Open
1 of 3 tasks

[gui] Prevent opening .so library file #2415

ilyasa1211 opened this issue Feb 19, 2025 · 3 comments
Labels
bug GUI Issues in jadx-gui module

Comments

@ilyasa1211
Copy link

ilyasa1211 commented Feb 19, 2025

Issue details

It seems like jadx not able to parse .so files, when I try to click it, it just froze my JADX.

I suggest that it should have a preventation such as warning pop up

Jadx version

1.5.1

Java version

23.0.1

OS

  • Windows
  • Linux
  • macOS
@ilyasa1211 ilyasa1211 added bug GUI Issues in jadx-gui module labels Feb 19, 2025
@jpstotz
Copy link
Collaborator

jpstotz commented Feb 20, 2025

Verified. Happens for me if the .so file is e.g. 12 MB of size.

According to VisualVM the main delay when loading is caused by calling setCaretPosition(..) in HexArea.load(). If I remove the calls the 12Mb .so file loaded on my system in 3 seconds. The the content appears, but then Jadx blocks again.

It seems like RSyntaxTextArea isn't optimized for documents with a size of 30MB+.

@iscle
Copy link
Contributor

iscle commented Feb 21, 2025

So, would a dialog saying something like "This file is bigger than X MB and could freeze JADX, are you sure you want to preview it?" would be enough?

Let me know your thoughts and I'll implement it!

@ilyasa1211
Copy link
Author

Verified. Happens for me if the .so file is e.g. 12 MB of size.

According to VisualVM the main delay when loading is caused by calling setCaretPosition(..) in HexArea.load(). If I remove the calls the 12Mb .so file loaded on my system in 3 seconds. The the content appears, but then Jadx blocks again.

It seems like RSyntaxTextArea isn't optimized for documents with a size of 30MB+.

I had no idea what those are, also yeah:

So, would a dialog saying something like "This file is bigger than X MB and could freeze JADX, are you sure you want to preview it?" would be enough?

Let me know your thoughts and I'll implement it!

That would be enough if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

3 participants