-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Jadx does not decompile layout and menu files and does not recognize the file extension for PNG files, layout files, and menu files #2421
Comments
An APK with 74 class files - impressive... The original error is the following one, which shows that this issue is closely related to #2420 and #2171:
|
Click to show error message
I found out why this error occurred while unzipping assets/dialog.zip in APK Manager. The dialog.zip file is password-protected, and the password is |
Can you please provide the path of the png files within your original APK file that can not be displayed correctly? |
|
Sorry I am not able to reproduce your problem. All png files I have looked at were shown as expected. Please provide a screenshot of Jadx with the problem. |
Use command line interface to reproduce this issue |
@jpstotz Any update??? |
Can you please post the command-line you use for decompiling? I don't use the non-UI version very often. |
I used windows cli |
I wasn't asking for the used terminal, but for the full Jadx command-line including all arguments you have executed, so I can execute the same detect what is going wrong. |
|
I can not reproduce your problem using latest version from GIT, the posted APK decompiles fine. I don't see any problem regarding layout and png files. Please try again using Jadx unstable version.. If you still encounter problems please post the full path of single APK entries and the content you get of this files after decompiling. |
@jpstotz am using latest unstable version where I first discovered this issue Here is the decompiled code: APK_Manager.zip |
@Beast833 Your uploaded file link is broken. Please also mention the file names of the files inside the ZIP which are not as they should be. |
No, the link is not broken it works fine for me JADX does not decompile the layout and menu files, and it does not recognize their file extensions. In other resource files where PNG files are used, JADX cannot recognize that they are PNG files and, accordingly, cannot name these files with the .png extension. |
Tried it on different systems with multiple web browsers. Only a page "Not found" comes. That file is most likely only accessible for your GitHub account |
Okay, try this google drive link: https://drive.google.com/file/d/1hxHgwAnrdkjC2FpRpqpHRMhCHoXULNuD/view?usp=drivesdk Or GitHub link: APK_Manager.zip |
Now I understand your problem. If you would have included a screenshot of the decompiled files in your initial post this would have saved us a lot of time. because the problem is simply that the PNG files are not saved with the .png file extension: The reason seems to be that the command-line Jadx version does not apply deobfuscation by default. Thus if you want Jadx to recover the file names you have to execute |
@jpstotz please take a look at its layout files where you will see the layout files are not decompiled and not having any .XML extension |
Issue details
JADX does not decompile the layout and menu files, and it does not recognize their file extensions. In other resource files where PNG files are used, JADX cannot recognize that they are PNG files and, accordingly, cannot name these files with the .png extension.
apk.zip
Relevant log output or stacktrace
Provide sample and class/method full name
No response
Jadx version
latest nightly version
The text was updated successfully, but these errors were encountered: