Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Code search includes excluded classes' code #2432

Open
2 of 3 tasks
eybisi opened this issue Mar 6, 2025 · 1 comment
Open
2 of 3 tasks

[gui] Code search includes excluded classes' code #2432

eybisi opened this issue Mar 6, 2025 · 1 comment
Assignees
Labels
bug GUI Issues in jadx-gui module

Comments

@eybisi
Copy link
Contributor

eybisi commented Mar 6, 2025

Issue details

Before building CodeSearchProviders, included classes are calculated at here but buildDecompileBatches includes dependencies of included classes which can include excluded classes. Is this intended?

Image

Jadx version

dev

Java version

21.0.5

OS

  • Windows
  • Linux
  • macOS
@eybisi eybisi added bug GUI Issues in jadx-gui module labels Mar 6, 2025
@skylot
Copy link
Owner

skylot commented Mar 6, 2025

Hm, looks like allClasses variable name is misleading because it doesn't include excluded classes 🤣
So, decompile batches should be built from actually ALL classes (here caching also assuming this).
After that, in CodeSearchProvider we should skip excluded classes, but still run decompilation for them (that needed for optimal decompilation performance and a reason why decompile batches was used).

@eybisi thanks for this issue report 👍

@skylot skylot self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

2 participants