[gui] cache clear/removal can be in parallel

[eybisi]

Issue details

Current implementation waits file deletion to continue. Same thing goes for cache clearing. Instead, after collecting files and directories, they can be deleted in parallel like following:

			Files.walkFileTree(dir, Collections.emptySet(), Integer.MAX_VALUE, new SimpleFileVisitor<>() {
				@Override
				public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
					files.add(file);
					return FileVisitResult.CONTINUE;
				}
				@Override
				public FileVisitResult postVisitDirectory(Path directory, IOException exc) {
					directories.add(directory);
					return FileVisitResult.CONTINUE;
				}
			});
			files.parallelStream().forEach(path -> {
				try {
					Files.delete(path);
				} catch (IOException e) {
					throw new JadxRuntimeException("Failed to delete directory " + path.toAbsolutePath(), e);
				}
			});
			for (Path directory : directories) {
				try {
					Files.delete(directory);
				} catch (IOException e) {
					throw new JadxRuntimeException("Failed to delete directory " + directory.toAbsolutePath(), e);
				}
			}

For my sample apk (on windows) current implementation takes around 10 seconds to delete. (decompiled all classes). By doing it parallel it takes around 1 second. Are there any drawbacks to delete files in parallel ?

Jadx version

dev

Java version

21.0.5

OS

• Windows
• Linux
• macOS

[skylot]

@eybisi looks great!

Are there any drawbacks to delete files in parallel ?

It is fine. The only possible drawback is that file system can change after files collection but before deletion start. This is not a big issue, and current implementation also have same drawback.