Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iac): removed FeatureFlagNotEnabled error and updated snyk-iac-test [IAC-3235] #5742

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ioannacaba
Copy link
Contributor

@ioannacaba ioannacaba commented Feb 18, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Removes the FeatureFlagNotEnabled error code that was mapping an error we added in snyk-iac-test to stop the scan of an IaC project when we run snyk iac test --report with the FF iacNewEngine being enabled. As we completed the CLI flow, we can now safely create an IaCV2 Project in the UI therefore we can stop adding an error when we try to do a scan from the CLI with iacNewEngine FF enabled and the --report command.
Update the snyk-iac-test to latest version where we removed this error.

Risk: low

Where should the reviewer start?

<local build> iac test --org=<org_that_has_iacv2>

How should this be manually tested?

Run comand: snyk iac test --report on an IaC Project, having the FF iacNewEngine enabled. This command should run a complete scan your IaC Project and create a target in the UI and not the error: flag --report is not yet supported when iacNewEngine flag is enabled.

Any background context you want to provide?

Changes included: https://github.com/snyk/snyk-iac-test/compare/v0.57.5...v0.57.7

What's the product update that needs to be communicated to CLI users?

What are the relevant tickets?

IAC-3235

@ioannacaba ioannacaba self-assigned this Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Warnings
⚠️

"fix: removed FeatureFlagNotEnabled iac error and upgraded snyk-iac-test version [IAC-3235]" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against c38a195

@andreeaneata andreeaneata changed the title fix: removed FeatureFlagNotEnabled iac error and upgraded snyk-iac-test version [IAC-3235] fix(iac): removed FeatureFlagNotEnabled iac error and upgraded snyk-iac-test version [IAC-3235] Feb 27, 2025
@ioannacaba ioannacaba force-pushed the fix/IAC-3235/remove-iacv2-error branch from 1992e43 to 2286cfd Compare February 27, 2025 14:40
@ioannacaba ioannacaba marked this pull request as ready for review February 27, 2025 15:10
@ioannacaba ioannacaba requested a review from a team as a code owner February 27, 2025 15:10
@ioannacaba ioannacaba changed the title fix(iac): removed FeatureFlagNotEnabled iac error and upgraded snyk-iac-test version [IAC-3235] fix(iac): removed FeatureFlagNotEnabled error and updated snyk-iac-test [IAC-3235] Feb 27, 2025
@ioannacaba ioannacaba force-pushed the fix/IAC-3235/remove-iacv2-error branch from 4cb67ac to dcc9a7b Compare February 27, 2025 15:29
@ioannacaba ioannacaba force-pushed the fix/IAC-3235/remove-iacv2-error branch from dcc9a7b to 79af452 Compare March 5, 2025 11:36
@ioannacaba ioannacaba force-pushed the fix/IAC-3235/remove-iacv2-error branch from 79af452 to c38a195 Compare March 5, 2025 15:38
@ioannacaba ioannacaba merged commit c3a719f into main Mar 6, 2025
7 checks passed
@ioannacaba ioannacaba deleted the fix/IAC-3235/remove-iacv2-error branch March 6, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants