Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add executeable flag to shell script #5755

Closed
wants to merge 1 commit into from

Conversation

nodeppo
Copy link

@nodeppo nodeppo commented Feb 25, 2025

What does this PR do?

I really liked the create-test-image.sh script locally, but it was missing the executeable flag:
image

I only did chmod +x scripts/create-test-image.sh to add the executeable flag, much like the create-build-image.sh script.

@nodeppo nodeppo requested a review from a team as a code owner February 25, 2025 08:44
@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
All committers have signed the CLA.

@nodeppo
Copy link
Author

nodeppo commented Feb 25, 2025

cc @j-luong as you did the original PR. I guess this was just missing?

@nodeppo nodeppo force-pushed the sh-x-flag branch 2 times, most recently from e20abca to 726e600 Compare February 26, 2025 19:05
@nodeppo nodeppo changed the title add executeable flag to shell script fix:add executeable flag to shell script Feb 26, 2025
@nodeppo nodeppo changed the title fix:add executeable flag to shell script fix: add executeable flag to shell script Feb 26, 2025
@nodeppo
Copy link
Author

nodeppo commented Feb 27, 2025

Sorry, @PeterSchafer, who do I need to bug to get a review? 🤣

@nodeppo nodeppo force-pushed the sh-x-flag branch 2 times, most recently from 97c18f5 to d14c1af Compare February 28, 2025 16:24
@nodeppo
Copy link
Author

nodeppo commented Mar 3, 2025

Could someone clarify if Snyk is open to accept external pull requests? @thisislawatts or @bastiandoetsch maybe?

Sorry, but I am just looking to get this simple change merged - or at least a note if external pull requests are not accepted.

@bastiandoetsch
Copy link
Contributor

Hi @nodeppo as stated in the README, Snyk is not open for external contribution:

Snyk CLI is closed to contributions
Effective July 22, 2024, Snyk CLI will no longer accept external contributions.

Due to the CLI's extensive usage and intricate nature, even minor modifications can have unforeseen consequences. Since introducing [release channels](https://snyk.io/blog/snyk-cli-semantic-versioning-and-release-channels/) to our code in April 2024, our focus has been on stabilizing releases. We believe this open-source, closed-contribution model best serves this goal.

In the spirit of transparency to Snyk customers and CLI users, we will continue to working in public. However, going forward, we are closed to contributions.

We appreciate and extend our gratitude to the Snyk community.

@bastiandoetsch
Copy link
Contributor

@j-luong as this is quite a reasonable PR, though, let's consider merging it :).

@nodeppo nodeppo force-pushed the sh-x-flag branch 2 times, most recently from 0101b7f to 407498e Compare March 3, 2025 15:42
@nodeppo
Copy link
Author

nodeppo commented Mar 3, 2025

Thanks @bastiandoetsch. I was looking at https://github.com/snyk/cli/blob/main/CONTRIBUTING.md and didn't see that message - sorry and thanks for clarifying.

@bastiandoetsch @j-luong let me know if this PR needs any more changes?

@nodeppo
Copy link
Author

nodeppo commented Mar 4, 2025

@j-luong as this is quite a reasonable PR, though, let's consider merging it :).

Can we? 😊

@nodeppo
Copy link
Author

nodeppo commented Mar 4, 2025

@bastiandoetsch could it be that @j-luong has notifications muted?

@nodeppo nodeppo force-pushed the sh-x-flag branch 2 times, most recently from 8058a6a to a53a079 Compare March 4, 2025 22:36
@nodeppo nodeppo marked this pull request as draft March 4, 2025 22:37
@nodeppo nodeppo marked this pull request as ready for review March 4, 2025 22:37
@bastiandoetsch
Copy link
Contributor

@bastiandoetsch could it be that @j-luong has notifications muted?

We all have I think, as github notifications come in 100s a day... I'll ping him internally.

@nodeppo
Copy link
Author

nodeppo commented Mar 5, 2025

We all have I think, as github notifications come in 100s a day... I'll ping him internally.

Ok, thanks, let's see.

@j-luong
Copy link
Contributor

j-luong commented Mar 5, 2025

Hi @nodeppo thanks for raising this; as already mentioned the Snyk CLI no longer accepts external contributions.

I've gone ahead and raised #5774 to get this change merged in.

@j-luong j-luong closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants