-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add executeable flag to shell script #5755
Conversation
cc @j-luong as you did the original PR. I guess this was just missing? |
e20abca
to
726e600
Compare
Sorry, @PeterSchafer, who do I need to bug to get a review? 🤣 |
97c18f5
to
d14c1af
Compare
Could someone clarify if Snyk is open to accept external pull requests? @thisislawatts or @bastiandoetsch maybe? Sorry, but I am just looking to get this simple change merged - or at least a note if external pull requests are not accepted. |
Hi @nodeppo as stated in the README, Snyk is not open for external contribution:
|
@j-luong as this is quite a reasonable PR, though, let's consider merging it :). |
0101b7f
to
407498e
Compare
Thanks @bastiandoetsch. I was looking at https://github.com/snyk/cli/blob/main/CONTRIBUTING.md and didn't see that message - sorry and thanks for clarifying. @bastiandoetsch @j-luong let me know if this PR needs any more changes? |
Can we? 😊 |
@bastiandoetsch could it be that @j-luong has notifications muted? |
8058a6a
to
a53a079
Compare
We all have I think, as github notifications come in 100s a day... I'll ping him internally. |
Ok, thanks, let's see. |
What does this PR do?
I really liked the

create-test-image.sh
script locally, but it was missing the executeable flag:I only did
chmod +x scripts/create-test-image.sh
to add the executeable flag, much like thecreate-build-image.sh
script.