fix: fix IPC error handling

[CatalinSnyk]

Pull Request Submission Checklist

• Follows CONTRIBUTING guidelines
• Includes detailed description of changes
• Contains risk assessment (Low | Medium | High)
• Highlights breaking API changes (if applicable)
• Links to automated tests covering new functionality
• Includes manual testing instructions (if necessary)
• Updates relevant GitBook documentation (PR link: ___)
• Includes product update to be announced in the next stable release notes

What does this PR do?

Previously, we would try to open the IPC error file even though the legacy cli run didn't result in any errors (this would not create the file as a result). The debug logs would log Failed to read error file: open <err-file-path>: no such file or directory, which might cause confusion for users.

Where should the reviewer start?

If the legacy CLI run resulted in an exit error with an exit code 0 or 1, we would not attempt to read from the error file; meaning if the exit code is greater or equal to 2, the error file should be checked against.

How should this be manually tested?

• run a commad that invokes the Typescript CLI and would exit with the exit code 0 or 1 -> the debug logs should not contain the message listed above
• run a commad that invokes the Typescript CLI and would exit with the exit code 0 or 1 -> the debug logs should contain a log about the error file being read

What's the product update that needs to be communicated to CLI users?

None

Other

• CLI-755

[j-luong]

question: is a test not necessary here?

[PeterSchafer]

Fair point! I wanted to have this fixed as I have mentioned this multiple times before, but covering it with a test is still reasonable and shouldn't take too much time.

[CatalinSnyk]

So I guess I should make another PR and get that merged on main right?

[github-actions]

	Warnings
⚠️	Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones. A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax. Files found: src/cli/ipc.ts src/cli/main.ts
⚠️	There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 96520e2