Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve unhandled errors #5773

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

PeterSchafer
Copy link
Collaborator

@PeterSchafer PeterSchafer commented Mar 4, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

This PR ensure that unhandled errors/exceptions are also passed between the Typescript and Golang CLI.

image

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/ipc.ts
  • src/cli/main.ts

Generated by 🚫 dangerJS against b78d8b0

@PeterSchafer PeterSchafer changed the title Fix/cli 638 handle unexpected errors fix: preserve unhandled errors Mar 4, 2025
@PeterSchafer PeterSchafer force-pushed the fix/CLI-638_handle_unexpected_errors branch 3 times, most recently from 4b76625 to 685d74c Compare March 4, 2025 21:45
@PeterSchafer PeterSchafer marked this pull request as ready for review March 4, 2025 21:46
@PeterSchafer PeterSchafer requested a review from a team as a code owner March 4, 2025 21:46
@PeterSchafer PeterSchafer force-pushed the fix/CLI-638_handle_unexpected_errors branch from 685d74c to 94a065e Compare March 4, 2025 22:01
@CatalinSnyk
Copy link
Contributor

nit: please also remove the await's from test/jest/unit/cli/ipc.spec.ts

@PeterSchafer PeterSchafer force-pushed the fix/CLI-638_handle_unexpected_errors branch from 94a065e to fb0a951 Compare March 5, 2025 09:55
@PeterSchafer PeterSchafer enabled auto-merge March 5, 2025 09:56
chore: use writeFileSync instead of async one
@PeterSchafer PeterSchafer force-pushed the fix/CLI-638_handle_unexpected_errors branch from fb0a951 to b78d8b0 Compare March 5, 2025 10:29
@PeterSchafer PeterSchafer merged commit 5637dec into main Mar 5, 2025
7 checks passed
@PeterSchafer PeterSchafer deleted the fix/CLI-638_handle_unexpected_errors branch March 5, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants