Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add, but ignore crypto helper #777

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bastiandoetsch
Copy link
Collaborator

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

Copy link
Contributor

@andrewrobinsonhodges-snyk andrewrobinsonhodges-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but you've got a local absolute path checked in, which should be removed before merge.

import * as fs from "node:fs";
import crypto from 'crypto';

const content = fs.readFileSync("/Users/bdoetsch/workspace/php-goof/exploits/gotcha_font.php", { encoding: 'utf8' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't check this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants