[WIP] Delete and recreate existing tag #175
Closed
+77
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most tags are considered immutable, so you have to explicity opt into this behaviour
movermeyer
force-pushed
the
mo.delete_existing_tag
branch
from
2300632 to
0586125
Compare
denibertovic
added a commit
to denibertovic/test-artifacts
that referenced
this pull request
Nov 16, 2021
this doesn't work unil this is merged: softprops/action-gh-release#175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #149
Fixes #171
Resolves 2934fce#r58642151
Both of these are a result of the tag associated with the release not updating to match the new
target_commitish.What approach did you choose and why?
I added a boolean
move_existing_tagflag that explicitly requests the deletion of the existing tag of an existing release.This is opt-in, explicit behaviour, since most tags are considered to be immutable. However, some projects may decide that
What should reviewers focus on?
Assume that I have no idea what's going on.
I tried to research whether there was any problem with deleting
lightweighttags, and everything I've found says that doing this is OK...WIP Status
target_committishvalues to their SHAs and compare those?The impact of these changes
Users will be able to opt into having update the commit that a tag points at as part of the release update.
Testing
Totally untested. WIP...