Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when files to release aren't found #155

Open
twojstaryzdomu opened this issue Sep 9, 2021 · 2 comments
Open

Fail when files to release aren't found #155

twojstaryzdomu opened this issue Sep 9, 2021 · 2 comments

Comments

@twojstaryzdomu
Copy link

twojstaryzdomu commented Sep 9, 2021

All too often getting 'not include valid file.'. Please enable a way to fail the release altogether when the release assets listed in files aren't found. Empty releases without assets may make little sense.

Case in point: an earlier job fails to populate its output variable that is used for release, resulting in an empty files parameter passed onto action-gh-release. It could be anything from syntax error to a faulty job.

action-gh-release needs a flag to fail when files is being set but may be empty due to a earlier problem. In that case, a release is a waste of effort.

@jane-rose
Copy link

Same here

@softprops
Copy link
Owner

softprops commented Dec 30, 2021

action-gh-release needs a flag to fail when files is being set but may be empty due to a earlier problem.

Have you tried using the fail_on_unmatched_files input?

Alternatively, if there were an earlier problem why not fail the workflow run at that point instead of proceeding on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants