Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob pattern with brace expansion not recognized #204

Open
swissmanu opened this issue Feb 2, 2022 · 1 comment
Open

Glob pattern with brace expansion not recognized #204

swissmanu opened this issue Feb 2, 2022 · 1 comment

Comments

@swissmanu
Copy link

swissmanu commented Feb 2, 2022

Hi there. First up, thank you for the action-gh-release action ❤️ I like how simple it makes interactions with the GitHub Releases feature.

To my (potential) bug report: I try to upload multiple files with different file extensions to my release. As I understand, files supports glob patterns:

jobs:
  bundle:
    runs-on: ${{ matrix.platform }}

    strategy:
      fail-fast: false
      matrix:
        platform: [ubuntu-latest, macos-latest, windows-latest]
        include:
          - platform: ubuntu-latest
            buildFolder: deb
            releaseAssetPattern: "*.{deb,AppImage.tar.gz,AppImage.tar.gz.sig}"
         # ... other platforms
    steps:
      # ... other steps
      - name: Upload Release Assets
        uses: softprops/action-gh-release@v1
        with:
          draft: true
          fail_on_unmatched_files: true
          files: ${{ format('./src-tauri/target/release/bundle/{0}/{1}', matrix.buildFolder, matrix.releaseAssetPattern) }}

At execution, I get the following behavior:

CleanShot 2022-02-02 at 14 59 58@2x

It seems like action-gh-release messes my pattern up somehow.

Are brace expansions supported at all? I had a quick look to the code and could not identify any such thing.

@swissmanu
Copy link
Author

I think I just found the bad guy:

.concat(line.split(","))

Would this be something you want to have fixed? Glad to help with a pull request.

swissmanu added a commit to swissmanu/action-gh-release that referenced this issue Feb 3, 2022
swissmanu added a commit to swissmanu/action-gh-release that referenced this issue Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant